Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Experiments settings #81396

Closed
smith opened this issue Oct 21, 2020 · 5 comments · Fixed by #81554
Closed

[APM] Experiments settings #81396

smith opened this issue Oct 21, 2020 · 5 comments · Fixed by #81554
Assignees
@smith
Labels
apm:service-overview enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.11.0

Comments

@smith
Copy link
Contributor

smith commented Oct 21, 2020 •
edited by ogupte
Loading

For the new service overview and Elastic Charts migration, create an "Experiments" section in Settings that uses per-space advanced settings saved object to toggle the settings.

It should contain a warning similar to the one in Stack Management's advanced settings.

To start it could contain a single toggle to enable/disable all experiments but we can expand it in the future to allow toggling of individual experiments.

See #81135 and #70290.
@smith smith added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result v7.11.0 apm:service-overview labels Oct 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith smith self-assigned this Oct 21, 2020
@sorenlouv
Copy link
Member

How is this related to the new service overview page, and the migration to elastic charts? I don't think the user should be able to switch between react-vis and elastic charts if that's what it means.

@formgeist
Copy link
Contributor

Correct me if I'm wrong, but I think we agreed that we'd implement this as a feature flag on master as we develop the overview page and replace the charts with Elastic Charts. That way internally running master we can switch between the WIP and the current setup.

@sorenlouv
Copy link
Member

We had a chat about this and agreed to proceed with a UI for experimental features. The only feature that we'll release as an experiment in 7.11 will be correlations (api + simple UI).
Elastic Charts will not be developed as an experiment. Instead we'll convert charts one-by-one.
It is still TBD whether Service overview page will be developed as an experiment. We are currently leaning towards not doing that to simplify matters.

@smith
Copy link
Contributor Author

smith commented Oct 26, 2020

It is still TBD whether Service overview page will be developed as an experiment. We are currently leaning towards not doing that to simplify matters.

I'm adding it in this PR. Since it's a completely standalone tab it only needs to be flagged in one place it should be simple enough.

@smith smith mentioned this issue Oct 26, 2020
Merged
smith added a commit to smith/kibana that referenced this issue Oct 27, 2020
@smith
Add advanced settings for APM
5e032f8 
* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.)
* Format settings pages to be more consistent.
smith added a commit that referenced this issue Oct 28, 2020
@smith
APM Experiments settings (#81554)
333f873 
* Add advanced settings for APM

* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes #81396.)
* Format settings pages to be more consistent.
smith added a commit to smith/kibana that referenced this issue Oct 28, 2020
@smith
APM Experiments settings (elastic#81554)
ad10532 
* Add advanced settings for APM

* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes elastic#81396.)
* Format settings pages to be more consistent.
smith added a commit that referenced this issue Oct 28, 2020
@smith
APM Experiments settings (#81554) (#81913)
d934d7b 
* Register advanced settings in server startup that show in the Kibana advanced settings UI. (Fixes #81396.)
* Format settings pages to be more consistent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smith smith

Labels
apm:service-overview enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.11.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

APM Experiments settings smith/kibana
4 participants
@smith @sorenlouv @formgeist @elasticmachine