Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix color coding for outlier detection. Fix nested fields for data grid. #80467

Merged
merged 1 commit into from
Oct 14, 2020
Merged

[ML] Fix color coding for outlier detection. Fix nested fields for data grid. #80467

merged 1 commit into from
Oct 14, 2020

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 14, 2020 •
edited
Loading

Summary

Part of #66383

Fixes regressions:

  • Fix for color coding for outlier detection due to updated feature influence format.
  • Fix for displaying cell values for nested fields.

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Transforms ML transforms Feature:Data Frame Analytics ML data frame analytics features v7.10.0 v7.11.0 labels Oct 14, 2020
@walterra walterra requested a review from a team as a code owner October 14, 2020 08:27
@walterra walterra self-assigned this Oct 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

peteharverson
peteharverson approved these changes Oct 14, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

From some quick testing, this may also fix a number of other issues related to displaying nested fields / fieldnames containing dots in the data grid - such as #65768 and two items in #66383.

@peteharverson peteharverson mentioned this pull request Oct 14, 2020
Closed
3 tasks
@walterra walterra merged commit 136eda1 into elastic:master Oct 14, 2020
@walterra walterra deleted the ml-fix-data-grid-nested-fields-color-coding branch October 14, 2020 12:06
@walterra walterra mentioned this pull request Oct 14, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Oct 14, 2020
@walterra
[ML] Fix color coding for outlier detection. Fix nested fields for da…
4bbb820 
…ta gird. (elastic#80467)

- Fix for color coding for outlier detection due to updated feature influence format.
- Fix for displaying cell values for nested fields.
@walterra walterra mentioned this pull request Oct 14, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request Oct 14, 2020
@walterra
[ML] Fix color coding for outlier detection. Fix nested fields for da…
aa4ef15 
…ta gird. (elastic#80467)

- Fix for color coding for outlier detection due to updated feature influence format.
- Fix for displaying cell values for nested fields.
walterra added a commit that referenced this pull request Oct 14, 2020
@walterra
[ML] Fix color coding for outlier detection. Fix nested fields for da…
4432ab4 
…ta gird. (#80467) (#80494)

- Fix for color coding for outlier detection due to updated feature influence format.
- Fix for displaying cell values for nested fields.
walterra added a commit that referenced this pull request Oct 14, 2020
@walterra
[ML] Fix color coding for outlier detection. Fix nested fields for da…
72b9219 
…ta gird. (#80467) (#80493)

- Fix for color coding for outlier detection due to updated feature influence format.
- Fix for displaying cell values for nested fields.
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
ml 11.3MB 11.3MB +462.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 18, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 Awaiting requested review from alvarezmelissa87

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features Feature:Transforms ML transforms :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.10.0 v7.11.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibanamachine @peteharverson @jgowdyelastic