-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Add super-fine option to grid/cluster layer #78201
Merged
thomasneirynck
merged 53 commits into
elastic:master
from
thomasneirynck:maps/es_mvt_grid_fix
Sep 23, 2020
Merged
[Maps] Add super-fine option to grid/cluster layer #78201
thomasneirynck
merged 53 commits into
elastic:master
from
thomasneirynck:maps/es_mvt_grid_fix
Sep 23, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasneirynck
changed the title
[Maps] Open [Maps] Add super-fine option to grid/cluster layer
[Maps] Add super-fine option to grid/cluster layer
Sep 22, 2020
This was referenced Sep 22, 2020
thomasneirynck
added
the
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
label
Sep 22, 2020
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review and tested in chrome
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
also approved by #76526 (review) |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Sep 23, 2020
Adds a super-fine option for grids and cluster layers. This uses the .mvt tile format to deliver the data.
thomasneirynck
added a commit
that referenced
this pull request
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo
Former Team Label for Geo Team. Now use Team:Presentation
release_note:enhancement
v7.10.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the original #76526 due to merge errors.
Summary
Adds super-fine option to grids/clusters and heatmaps layers. This uses vector-tiles as the back-end data format.
Addition of the super-fine option
The super-fine option currently returns tiles with a resolution of 128x128 = ((2^7)^2) . This is well under the limit of 256x256 of Elasticsearch.
Making this much finer though will start to create sparsity-artefacts when zooming in on data. This probably needs some experimentation.
Adds a new backend route
mvt/getGridTile
This produces the tile. It either returns a tile with cluster-bubbles or with rectangular cells, depending on the
ESGeoGridSourceDescriptor.requestType
-configuration.Moved ES-response decoding utils to
common
for reuse on server-backend.Enabled for grid and cluster layer
(not heatmap just yet)
ESGeoGridSource
now implementsITiledSingleLayerVectorSource
Styling limitation on countable-metrics
Countable metrics cannot be auto-styled using a backend meta-call for ES extented-stats This runs into a similar limitation as for 3rd party vector tiles, where colors can only be configured with custom-ranges (iso. default color-ramps) and that size cannot be styled by-value (cf. #62867).
Checklist
Delete any items that are not applicable to this PR.
[ ] Documentation was added for features that require explanation or tutorialsFor maintainers
Todo
supportsAutoDomain
is overloaded)