[Logs UI] Replace deprecated getInjectedVar with NP spaces API #74280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
v8.0.0
Feature:Logs UI
weltenwort
commented
Aug 4, 2020
|
|
||
| export type PluginKibanaContextValue = CoreStart & InfraClientStartDeps; | ||
|
|
||
| export const createKibanaContextForPlugin = (core: CoreStart, pluginsStart: InfraClientStartDeps) => |
There was a problem hiding this comment.
ℹ️ This in combination with the useKibanaContextForPlugin() hook below aims at providing a typed Kibana context value as recommended by the kibana_react plugin.
weltenwort
commented
Aug 4, 2020
| import { DataPublicPluginStart } from '../../../../src/plugins/data/public'; | ||
| import { HomePublicPluginSetup } from '../../../../src/plugins/home/public'; | ||
| import { | ||
| import type { CoreSetup, CoreStart, Plugin as PluginClass } from 'kibana/public'; |
There was a problem hiding this comment.
ℹ️ These explicit type imports just try to make sure we don't accidentally pull runtime code into the eagerly loaded entry point bundle.
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
added
the
release_note:skip
Kerry350
approved these changes
Aug 6, 2020
|
|
||
| // This is a rather crude way of guarding the dependent providers against | ||
| // arguments that are only made available asynchronously. Ideally, we'd use | ||
| // React concurrent mode and Suspense in oder to handle that more gracefully. |
There was a problem hiding this comment.
Agreed 👍 (Nit: there's a small typo in the comment with oder)
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
async chunks size
History
To update your PR or re-run it, just comment with: |
weltenwort
added a commit
that referenced
this pull request
Aug 6, 2020
… (#74517) * Replace getInjectedVar() with NP spaces API * Fix typo in comment * Fix typo in comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the use of
getInjectedVar()in order to access the active space's id withgetActiveSpace()from thespacesplugin. It introduces some crude guard against the new asynchronous availability of the id which differs from the previous, synchronous availability.closes #68142