Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs App] Use new getActiveSpace function, abandon getInjectedVar() #68142

Closed
jasonrhodes opened this issue Jun 3, 2020 · 2 comments · Fixed by #74280
Closed

[Logs App] Use new getActiveSpace function, abandon getInjectedVar() #68142

jasonrhodes opened this issue Jun 3, 2020 · 2 comments · Fixed by #74280
Assignees
Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Milestone

Comments

@jasonrhodes
Copy link
Member

This call here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/infra/public/utils/use_kibana_space_id.ts#L16 is apparently the last thing that is keeping Kibana's legacy spaces plugin alive.

We need to replace that call with the new platform spaces plugin's getActiveSpace() method: https://github.com/elastic/kibana/blob/master/x-pack/plugins/spaces/public/plugin.tsx#L94-L97

Note: the new platform version is an async call, so the useKibanaSpaceId hook will need to be re-thought.

Thanks for bringing this to our attention, @legrego ! <3

@jasonrhodes jasonrhodes added chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jun 3, 2020
@jasonrhodes jasonrhodes added this to the Logs UI 7.9 milestone Jun 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@joshdover
Copy link
Contributor

Just an FYI, this may need to be prioritized for early 7.10. We're working on removing legacy plugin support with a focus on frontend plugins first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants