Initial work on uptime for observability homepage API #70135

andrewvc · 2020-06-26T22:50:04Z

Resolves #69716 by adding a data connector for uptime data.

Testing

You can test this by adding following code

const getData = async () => {
    const params = {
      startTime: '2020-06-29T11:38:23.747Z',
      endTime: '2020-06-29T12:08:23.748Z',
      bucketSize: '30s',
    };
    const uptimeData = await getDataHandler('uptime')?.fetchData(params);
    console.log('####', { uptimeData });
  };
  getData();

in file https://github.com/elastic/kibana/blob/master/x-pack/plugins/observability/public/application/index.tsx#L15

Resolves elastic#69716

elasticmachine · 2020-06-26T22:50:09Z

Pinging @elastic/uptime (Team:uptime)

cauemarcondes · 2020-06-27T10:46:35Z

x-pack/plugins/uptime/public/apps/plugin.ts

@@ -63,6 +67,58 @@ export class UptimePlugin
      });
    }

+    // This doesn't actually work


Hi @andrewvc I checked out your branch and I didn't see any problem. Can you tell me why you mentioned that it doesn't work?

cauemarcondes · 2020-06-30T08:12:35Z

x-pack/plugins/uptime/public/apps/uptime_overview_fetcher.ts

+import { fetchPingHistogram, fetchSnapshotCount } from '../state/api';
+import { UptimeFetchDataResponse } from '../../../observability/public/typings/fetch_data_response';
+
+export async function fetchUptimeOverviewData({ startTime, endTime, bucketSize }) {


I noticed you're not using the bucketSize, could you tell me why? We want to show the same information in the x-axis for all charts in the Observability page.

@cauemarcondes i have updated to use the bucketSize

x-pack/plugins/uptime/public/apps/uptime_overview_fetcher.ts

cauemarcondes

LGTM

justinkambic

Had a question about some of the new server code this change is adding. If the acceptance criteria is that I'm able to see data when executing the code included in the testing instructions then this otherwise is looking good to me.

x-pack/plugins/uptime/server/lib/requests/get_ping_histogram.ts

x-pack/plugins/uptime/public/apps/plugin.ts

x-pack/plugins/uptime/public/apps/uptime_overview_fetcher.ts

kibanamachine · 2020-06-30T17:26:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 38b89a5

Build metrics

✅ unchanged

History

💚 Build #57506 succeeded 628f71c
💔 Build #57283 failed 8fd2418
💔 Build #56895 failed 9aa5b81

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

justinkambic

LGTM!

Co-authored-by: Shahzad <shahzad31comp@gmail.com>

Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>

…-based-rbac * upstream/master: (38 commits) Move logger configuration integration test to jest (elastic#70378) Changes observability plugin codeowner (elastic#70439) update (elastic#70424) [Logs UI] Avoid CCS-incompatible index name resolution (elastic#70179) Enable "Explore underlying data" actions for Lens visualizations (elastic#70047) Initial work on uptime homepage API (elastic#70135) expressions indexPattern function (elastic#70315) [Discover] Deangularization context error message refactoring (elastic#70090) [Lens] Add "no data" popover (elastic#69147) [Lens] Move chart switcher over (elastic#70182) chore: add missing mjs extension (elastic#70326) [Lens] Multiple y axes (elastic#69911) skip flaky suite (elastic#70386) fix bug to add timeline to case (elastic#70343) [QA][Code Coverage] Drop catchError and use try / catch instead, (elastic#69198) [QA] [Code Coverage] Integrate with Team Assignment Pipeline and Add Research and Development Indexes and Cluster (elastic#69348) [Metrics UI] Add context.reason and alertOnNoData to Inventory alerts (elastic#70260) Resolver refactoring (elastic#70312) [Ingest Manager] Fix agent ack after input format change (elastic#70335) [eslint][ts] Enable prefer-ts-expect-error (elastic#70022) ...

Initial work on uptime homepage API

deab3de

Resolves elastic#69716

andrewvc requested review from shahzad31 and justinkambic June 26, 2020 22:50

andrewvc requested a review from a team as a code owner June 26, 2020 22:50

botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Jun 26, 2020

andrewvc added enhancement New value added to drive a business result release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 26, 2020

Fmt

9aa5b81

cauemarcondes reviewed Jun 27, 2020

View reviewed changes

shahzad31 added 2 commits June 29, 2020 19:33

Merge branch 'master' into uptime-homepage-api

0c514bf

move funtion to new file

8fd2418

shahzad31 requested a review from cauemarcondes June 29, 2020 19:21

cauemarcondes reviewed Jun 30, 2020

View reviewed changes

shahzad31 added 2 commits June 30, 2020 13:59

Merge branch 'master' into uptime-homepage-api

dd18ab9

update to use bucket size

628f71c

cauemarcondes reviewed Jun 30, 2020

View reviewed changes

x-pack/plugins/uptime/public/apps/uptime_overview_fetcher.ts Show resolved Hide resolved

cauemarcondes approved these changes Jun 30, 2020

View reviewed changes

justinkambic requested changes Jun 30, 2020

View reviewed changes

remove unnecessary change

ad6d359

shahzad31 force-pushed the uptime-homepage-api branch from ec837f7 to ad6d359 Compare June 30, 2020 15:48

unnecessary coe

38b89a5

shahzad31 requested review from justinkambic and removed request for shahzad31 June 30, 2020 17:30

shahzad31 approved these changes Jun 30, 2020

View reviewed changes

justinkambic approved these changes Jun 30, 2020

View reviewed changes

shahzad31 merged commit e8cf08f into elastic:master Jul 1, 2020

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jul 1, 2020

Initial work on uptime homepage API (elastic#70135)

82e3f10

Co-authored-by: Shahzad <shahzad31comp@gmail.com>

shahzad31 mentioned this pull request Jul 1, 2020

[7.x] Initial work on uptime homepage API (#70135) #70408

Merged

shahzad31 changed the title ~~Initial work on uptime homepage API~~ Initial work on uptime for observability homepage API Jul 1, 2020

Bamieh pushed a commit to Bamieh/kibana that referenced this pull request Jul 1, 2020

Initial work on uptime homepage API (elastic#70135)

c7842bb

Co-authored-by: Shahzad <shahzad31comp@gmail.com>

shahzad31 mentioned this pull request Jul 1, 2020

[Uptime] Fix type issue cause by conflicting merged PR's #70424

Merged

shahzad31 added a commit that referenced this pull request Jul 1, 2020

[7.x] Initial work on uptime homepage API (#70135) (#70408)

a6c6133

Co-authored-by: Shahzad <shahzad31comp@gmail.com> Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>

andrewvc deleted the uptime-homepage-api branch July 6, 2020 22:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial work on uptime for observability homepage API #70135

Initial work on uptime for observability homepage API #70135

andrewvc commented Jun 26, 2020 •

edited by shahzad31

Loading

elasticmachine commented Jun 26, 2020

cauemarcondes Jun 27, 2020

cauemarcondes Jun 30, 2020

shahzad31 Jun 30, 2020

cauemarcondes left a comment

justinkambic left a comment

kibanamachine commented Jun 30, 2020

justinkambic left a comment

Initial work on uptime for observability homepage API #70135

Initial work on uptime for observability homepage API #70135

Conversation

andrewvc commented Jun 26, 2020 • edited by shahzad31 Loading

Testing

elasticmachine commented Jun 26, 2020

cauemarcondes Jun 27, 2020

Choose a reason for hiding this comment

cauemarcondes Jun 30, 2020

Choose a reason for hiding this comment

shahzad31 Jun 30, 2020

Choose a reason for hiding this comment

cauemarcondes left a comment

Choose a reason for hiding this comment

justinkambic left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 30, 2020

💚 Build Succeeded

Build metrics

History

justinkambic left a comment

Choose a reason for hiding this comment

andrewvc commented Jun 26, 2020 •

edited by shahzad31

Loading