[Ingest Manager] Kibana, not EPR, controls removable packages #69761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfsiii
commented
Jun 24, 2020
| @@ -1712,6 +1712,198 @@ | |||
| }, | |||
| "success": true | |||
| } | |||
| }, | |||
| "required-package": { | |||
There was a problem hiding this comment.
Added an example for a package which has removable: false
jfsiii
commented
Jun 24, 2020
| "name": "endpoint", | ||
| "version": "0.3.0", | ||
| "internal": false, | ||
| "removable": false |
There was a problem hiding this comment.
is a required package
jfsiii
commented
Jun 24, 2020
| endpoint: true, | ||
| }; | ||
|
|
||
| export function isRequiredPackage(value: string): value is RequiredPackage { |
There was a problem hiding this comment.
This tests based only on the package name, not name + version. We can add versions in later if we need to
jfsiii
added
Team:Fleet
jfsiii
requested review from
neptunian,
paul-tavares and
ruflin
and removed request for
neptunian and
paul-tavares
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
ruflin
approved these changes
Jun 24, 2020
jfsiii
commented
Jun 24, 2020
| @@ -58,7 +58,6 @@ export interface RegistryPackage { | |||
| icons?: RegistryImage[]; | |||
| assets?: string[]; | |||
| internal?: boolean; | |||
| removable?: boolean; | |||
There was a problem hiding this comment.
No longer coming from the Registry so remove from its type
jfsiii
commented
Jun 24, 2020
| @@ -206,6 +205,7 @@ interface PackageAdditions { | |||
| title: string; | |||
| latestVersion: string; | |||
| assets: AssetsGroupedByServiceByType; | |||
| removable?: boolean; | |||
There was a problem hiding this comment.
Add to Ingest's Package type
neptunian
approved these changes
Jun 24, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricspage load asset sizebeta
History
To update your PR or re-run it, just comment with: |
jfsiii
pushed a commit
to jfsiii/kibana
that referenced
this pull request
Jun 25, 2020
…c#69761) * Kibana, not EPR, controls removable packages * Add 'removable' property to OpenAPI PackageInfo schema * Undo changes to example /packages API output Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
ruflin
pushed a commit
that referenced
this pull request
Jun 25, 2020
#69906) * Kibana, not EPR, controls removable packages * Add 'removable' property to OpenAPI PackageInfo schema * Undo changes to example /packages API output Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 25, 2020
* master: (45 commits) [QA] Unskip functional tests (elastic#69760) [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715) Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863) PR: Provide limit warnings to user when API limits are reached. (elastic#69590) [Maps] Remove broken button (elastic#69853) Makes usage collection methods available on start (elastic#69836) [SIEM][CASE] Improve Jira's labelling (elastic#69892) [Logs UI] Access ML via the programmatic plugin API (elastic#68905) [ML] DF Analytics: Creation wizard part 3 (elastic#69456) Update Resolver generator script documentation (elastic#69912) [ML] Changes View results button text on new job page (elastic#69809) Add master branch to backport config (elastic#69893) [Ingest Manager] Kibana, not EPR, controls removable packages (elastic#69761) unskips 'Events columns' test (elastic#69684) [ML] Changes the ML overview empty analytics panel text (elastic#69801) [DOCS] Emphasizes where File Data Visualizer is located. (elastic#69812) add the `exactRoute` property to app registration (elastic#69772) Bump backport to 5.4.6 (elastic#69880) [Logs UI] ML log integration splash screen (elastic#69288) Clean up TSVB type client code to conform to the schema (elastic#68519) ...
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Keep a list of required packages in Ingest Manager instead of relying on the Registry
closes https://github.com/elastic/endpoint-app-team/issues/481
Tested by pointing to local registry from elastic/package-registry#532 built using