Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Functional tests - stabilize typing in DFA mml input #66706

Merged
merged 1 commit into from
May 15, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented May 15, 2020

Summary

This PR wraps the model memory value setting during data frame analytics job creation in a retry.

In some cases on cloud execution, the value set by the automation was modified by an api call coming back while typing, which leads to values like 12mb5mb.

A similar fix already exists in the anomaly detection area #63091

Closes #55772

@pheyos pheyos requested a review from a team as a code owner May 15, 2020 09:53
@pheyos pheyos self-assigned this May 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pheyos pheyos merged commit e28afff into elastic:master May 15, 2020
@pheyos pheyos deleted the stabilize_dfa_mml_typing branch May 15, 2020 12:34
pheyos added a commit to pheyos/kibana that referenced this pull request May 15, 2020
)

This PR wraps the model memory value setting during data frame analytics job creation in a retry.
pheyos added a commit to pheyos/kibana that referenced this pull request May 15, 2020
)

This PR wraps the model memory value setting during data frame analytics job creation in a retry.
pheyos added a commit that referenced this pull request May 15, 2020
…66725)

This PR wraps the model memory value setting during data frame analytics job creation in a retry.
pheyos added a commit that referenced this pull request May 15, 2020
…66727)

This PR wraps the model memory value setting during data frame analytics job creation in a retry.
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 15, 2020
* master: (191 commits)
  [Maps] Get number of categories from palette (elastic#66454)
  move oss features registration to KP (elastic#66524)
  [kbn/plugin-helpers] typescript-ify (elastic#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746)
  FTR: move basic services under common folder (elastic#66563)
  Migrate Beats Management UI to KP (elastic#65791)
  [CI] Add 20 minutes to overall build timeout
  lint import from restricted zones for export exressions (elastic#66588)
  [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332)
  KP plugins shouldn't need package.json (elastic#66654)
  Replace agent metrics link with the new one (elastic#66632)
  [CI] Add one retry to setup step (elastic#66638)
  [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580)
  [docLinks] Add docLinks to CoreSetup. (elastic#66631)
  [DOCS] Rename monitoring collection from internal to legacy (elastic#65781)
  unskip newsfeed tests (elastic#66562)
  [NP] Migrate uiSettings owned by Kibana app (elastic#64321)
  [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706)
  [Map] return bounding box for static feature collection without joins (elastic#66607)
  remove trailing slash in graph sample data links (elastic#66358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants