Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KP plugins shouldn't need package.json #66654

Merged

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented May 14, 2020

It's so easy for one accident in an example plugin to proliferate! This was my original bad, I think all the others just followed suit.

@stacey-gammon
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon marked this pull request as ready for review May 15, 2020 14:39
@stacey-gammon stacey-gammon requested a review from a team as a code owner May 15, 2020 14:39
@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0 labels May 15, 2020
@stacey-gammon
Copy link
Contributor Author

stacey-gammon commented May 15, 2020

Thanks for sharing the issue @Dosant. I don't see anything in there about requiring a package.json file, unless I missed something? cc @spalger

@Dosant
Copy link
Contributor

Dosant commented May 15, 2020

@stacey-gammon, I deleted original comment, as in 30 seconds realised that I mistaken kibana.json and package.json. .. sorry for confusion. All good 👍

#64843

Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely followed example with package.json's :D

@stacey-gammon stacey-gammon merged commit 976ff05 into elastic:master May 15, 2020
stacey-gammon added a commit to stacey-gammon/kibana that referenced this pull request May 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@stacey-gammon stacey-gammon deleted the 2020-05-14-remove-package-json branch May 15, 2020 15:36
stacey-gammon added a commit that referenced this pull request May 15, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 15, 2020
* master: (191 commits)
  [Maps] Get number of categories from palette (elastic#66454)
  move oss features registration to KP (elastic#66524)
  [kbn/plugin-helpers] typescript-ify (elastic#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746)
  FTR: move basic services under common folder (elastic#66563)
  Migrate Beats Management UI to KP (elastic#65791)
  [CI] Add 20 minutes to overall build timeout
  lint import from restricted zones for export exressions (elastic#66588)
  [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332)
  KP plugins shouldn't need package.json (elastic#66654)
  Replace agent metrics link with the new one (elastic#66632)
  [CI] Add one retry to setup step (elastic#66638)
  [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580)
  [docLinks] Add docLinks to CoreSetup. (elastic#66631)
  [DOCS] Rename monitoring collection from internal to legacy (elastic#65781)
  unskip newsfeed tests (elastic#66562)
  [NP] Migrate uiSettings owned by Kibana app (elastic#64321)
  [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706)
  [Map] return bounding box for static feature collection without joins (elastic#66607)
  remove trailing slash in graph sample data links (elastic#66358)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants