Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Fix test to reflect model memory limit change. #65967

Merged
merged 1 commit into from
May 11, 2020
+10 −3
Merged

[ML] Anomaly Detection: Fix test to reflect model memory limit change. #65967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions x-pack/plugins/ml/server/models/job_validation/job_validation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ const callWithRequest: APICaller = (method: string) => {
if (method === 'fieldCaps') {
resolve({ fields: [] });
return;
} else if (method === 'ml.info') {
resolve({
limits: {
effective_max_model_memory_limit: '100MB',
max_model_memory_limit: '1GB',
},
});
}
resolve({});
}) as Promise<any>;
Expand Down Expand Up @@ -291,7 +298,7 @@ describe('ML - validateJob', () => {
});

// Failing https://github.com/elastic/kibana/issues/65865
it.skip('basic validation passes, extended checks return some messages', () => {
it('basic validation passes, extended checks return some messages', () => {
const payload = getBasicPayload();
return validateJob(callWithRequest, payload).then(messages => {
const ids = messages.map(m => m.id);
Expand All @@ -305,7 +312,7 @@ describe('ML - validateJob', () => {
});

// Failing https://github.com/elastic/kibana/issues/65866
it.skip('categorization job using mlcategory passes aggregatable field check', () => {
it('categorization job using mlcategory passes aggregatable field check', () => {
const payload: any = {
job: {
job_id: 'categorization_test',
Expand Down Expand Up @@ -372,7 +379,7 @@ describe('ML - validateJob', () => {
});

// Failing https://github.com/elastic/kibana/issues/65867
it.skip('script field not reported as non aggregatable', () => {
it('script field not reported as non aggregatable', () => {
const payload: any = {
job: {
job_id: 'categorization_test',
Expand Down