Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Anomaly Detection: Fix test to reflect model memory limit change. #65967

Merged
merged 1 commit into from
May 11, 2020
Merged

[ML] Anomaly Detection: Fix test to reflect model memory limit change. #65967

merged 1 commit into from
May 11, 2020

Conversation

walterra
Copy link
Contributor

Summary

Adapt jest test mocks to consider update introduced in #65652.

Checklist

For maintainers

@walterra walterra added regression :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 labels May 11, 2020
@walterra walterra requested a review from a team as a code owner May 11, 2020 07:39
@walterra walterra self-assigned this May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

jgowdyelastic
jgowdyelastic approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit e148eb4 into elastic:master May 11, 2020
@walterra walterra deleted the ml-fix-jest-test-mock-20200511 branch May 11, 2020 09:41
@walterra walterra mentioned this pull request May 11, 2020
Merged
walterra added a commit to walterra/kibana that referenced this pull request May 11, 2020
@walterra
[ML] Anomaly Detection: Fix test to reflect model memory limit change. (
fd18214 
elastic#65967)

Adapt jest test mocks to consider update introduced in elastic#65652.
# Conflicts:
#	x-pack/plugins/ml/server/models/job_validation/job_validation.test.ts
@walterra walterra mentioned this pull request May 11, 2020
Merged
walterra added a commit that referenced this pull request May 11, 2020
@walterra
[ML] Anomaly Detection: Fix test to reflect model memory limit change. (
e73ee03 
#65967) (#65983)

Adapt jest test mocks to consider update introduced in #65652.
walterra added a commit that referenced this pull request May 11, 2020
@walterra
[ML] Anomaly Detection: Fix test to reflect model memory limit change. (
a7797bc 
#65967) (#65984)

Adapt jest test mocks to consider update introduced in #65652.
This was referenced May 19, 2020
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@walterra walterra

Labels
Feature:Anomaly Detection ML anomaly detection :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@walterra @elasticmachine @kibanamachine @peteharverson @jgowdyelastic