Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Hide selector helper in Anomaly Explorer swimlane #65522

Merged
merged 1 commit into from
May 7, 2020
Merged

[ML] Hide selector helper in Anomaly Explorer swimlane #65522

merged 1 commit into from
May 7, 2020

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented May 6, 2020 •
edited
Loading

Summary

Fixes #62615. Hides a square selector helper on the Anomaly Explorer page when the user selects the swimlane elements.

  • I didn't manage to reproduce the issue on the Single Metric Viewer time-range selection control.

May-06-2020 19-27-37

@darnautov darnautov requested review from a team as code owners May 6, 2020 17:30
@darnautov darnautov self-assigned this May 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov changed the title [ML] hide drag selector [ML] Hide selector helper May 6, 2020
jgowdyelastic
jgowdyelastic approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@walterra
Copy link
Contributor

walterra commented May 7, 2020

The code is only about Anomaly Explorer but the original issue also describes the same when using the brush on the Single Metric Viewer, will this PR also fix it?

@darnautov
Copy link
Contributor Author

The code is only about Anomaly Explorer but the original issue also describes the same when using the brush on the Single Metric Viewer, will this PR also fix it?

hey @walterra , please check the PR description 🙂
Also in the original issue mentioned It seems this only happens under certain (currently unknown) circumstances. I spent a fair amount of time trying to reproduce but it seems like the time-range selector on Single Metric Viewer is not affected by this problem.

peteharverson
peteharverson approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

I tried and failed to reproduce the original issue on the Single Metric Viewer brush selection. I only saw it in the Anomaly Explorer swimlane.

@peteharverson peteharverson changed the title [ML] Hide selector helper [ML] Hide selector helper in Anomaly Explorer swimlane May 7, 2020
@darnautov darnautov merged commit ab5943c into elastic:master May 7, 2020
@darnautov darnautov deleted the ML-62615-fix-range-selection branch May 7, 2020 10:10
darnautov added a commit to darnautov/kibana that referenced this pull request May 7, 2020
@darnautov
[ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
d3a0332
@darnautov darnautov mentioned this pull request May 7, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request May 7, 2020
@darnautov
[ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
d5ea74f
@darnautov darnautov mentioned this pull request May 7, 2020
Merged
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 7, 2020
@gmmorris
Merge remote-tracking branch 'upstream/master' into event-log/fix-adi…
1ff566d 
…ttional-flaky

* upstream/master: (49 commits)
  Move remaining home assets to the new platform (elastic#65053)
  Change the copy and the id from blacklist to block list for consistency (elastic#65419)
  [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
  [ML] Fix the limit control on the Anomaly explorer page (elastic#65459)
  [Mappings editor] Add component integration tests (elastic#63853)
  [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456)
  [Logs UI] Disable search bar when live stream is on. (elastic#65491)
  fix SavedObjectMigrationMap type (elastic#65569)
  [Uptime] Improve cert flaky test (elastic#65458)
  [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532)
  [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508)
  [APM] Remove link from active page in the breadcrumb (elastic#65473)
  [SIEM] Fixes test flakiness (elastic#65510)
  [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471)
  Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780)
  move core provier to NP. allows to run tests on every page (elastic#64929)
  Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201)
  [functional tests] add some missing awaits (elastic#65566)
  Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539)
  [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 7, 2020
@gmmorris
Merge branch 'master' into alerting/lazy-load-actions
0e1656e 
* master:
  [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494)
  [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595)
  [Lens] Use rules of hooks with linting (elastic#65593)
  [ML] Migrate server side Mocha tests to Jest. (elastic#65651)
  Fixes the client to setup SSL with the CA certificates for testing (elastic#65598)
  reduce uptime plugin initial bundle size (elastic#65257)
  [ML] Consolidating shared types and util functions (elastic#65247)
  [Drilldowns] Preserve state when selecting different action factory (elastic#65074)
  Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756)
  Move remaining home assets to the new platform (elastic#65053)
  Change the copy and the id from blacklist to block list for consistency (elastic#65419)
  [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
  [ML] Fix the limit control on the Anomaly explorer page (elastic#65459)
  [Mappings editor] Add component integration tests (elastic#63853)
  [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456)
  [Logs UI] Disable search bar when live stream is on. (elastic#65491)
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 7, 2020
@gmmorris
Merge branch 'alerting/lazy-load-actions' into alerting/lazy-load-com…
c436e8d 
…ponents

* alerting/lazy-load-actions:
  align and style loading indicator
  [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494)
  [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595)
  [Lens] Use rules of hooks with linting (elastic#65593)
  [ML] Migrate server side Mocha tests to Jest. (elastic#65651)
  Fixes the client to setup SSL with the CA certificates for testing (elastic#65598)
  reduce uptime plugin initial bundle size (elastic#65257)
  [ML] Consolidating shared types and util functions (elastic#65247)
  [Drilldowns] Preserve state when selecting different action factory (elastic#65074)
  Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756)
  Move remaining home assets to the new platform (elastic#65053)
  Change the copy and the id from blacklist to block list for consistency (elastic#65419)
  [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522)
  [ML] Fix the limit control on the Anomaly explorer page (elastic#65459)
  [Mappings editor] Add component integration tests (elastic#63853)
  [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456)
  [Logs UI] Disable search bar when live stream is on. (elastic#65491)
darnautov added a commit that referenced this pull request May 7, 2020
@darnautov @elasticmachine
[ML] Hide selector helper in Anomaly Explorer swimlane (#65522) (#65650)
92eee1b 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
darnautov added a commit that referenced this pull request May 7, 2020
@darnautov @elasticmachine
[ML] Hide selector helper in Anomaly Explorer swimlane (#65522) (#65649)
a15ced2 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Single metric viewer - mouse selection shape on time slider handle move
6 participants
@darnautov @elasticmachine @kibanamachine @walterra @peteharverson @jgowdyelastic