-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors #65201
Conversation
…eystore and action types for preconfigured connectors
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but noted that email sender
needs to change to from
, and made a few other comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, better having all the pre-configured action info on one page!
I'm not sure about the idea of "preconfigured action types" (kinda long comment in the review), but perhaps will be easier for customers to understand. I noted some possible simplifications in comments as well.
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…eystore and action types for preconfigured connectors (elastic#65201) * Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors * Fixed due to comments and merged two preconfig pages * Fixed due to review comments * Update docs/user/alerting/action-types/index.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fixed due to comments * - Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…eystore and action types for preconfigured connectors (#65201) (#65599) * Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors * Fixed due to comments and merged two preconfig pages * Fixed due to review comments * Update docs/user/alerting/action-types/index.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fixed due to comments * - Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
* master: (42 commits) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) Migrate Coordinate Maps to NP (elastic#64668) Updating Canvas location in nav (elastic#65519) [SIEM][Lists] Fixes up contracts to work outside of requests [Lens] Remove "inside only" option for treemap labels (elastic#65363) [Uptime] Add TLS alert functional test (elastic#65303) Fix z-index of kbnLoadingIndicator (elastic#65521) Fixed indice assertion to loop through expected keys (elastic#64684) ...
…ttional-flaky * upstream/master: (49 commits) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) ...
…eystore and action types for preconfigured connectors (elastic#65201) * Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors * Fixed due to comments and merged two preconfig pages * Fixed due to review comments * Update docs/user/alerting/action-types/index.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fixed due to comments * - Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
…eystore and action types for preconfigured connectors (#65201) (#66126) * Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors * Fixed due to comments and merged two preconfig pages * Fixed due to review comments * Update docs/user/alerting/action-types/index.asciidoc Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> * Fixed due to comments * - Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com> Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
Resolve #63984 and #63991