Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix discover preserve url #63580

Merged
merged 3 commits into from
Apr 16, 2020

Conversation

flash1293
Copy link
Contributor

Fixes #62902

This stabilizes the discover test - instead of using a combination of appsMenu.clickLink and discover.waitUntilSearchingHasFinished to wait for stabilization of the discover page, this PR switches to the battle-tested header.clickDiscover shortcut.

@flash1293 flash1293 added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 15, 2020
@flash1293
Copy link
Contributor Author

@flash1293 flash1293 marked this pull request as ready for review April 15, 2020 15:35
@flash1293 flash1293 requested a review from a team April 15, 2020 15:35
@flash1293 flash1293 added the Feature:Discover Discover Application label Apr 15, 2020
@flash1293
Copy link
Contributor Author

Flaky test runner didn't report any failures.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test but the flaky test runner is very convincing 👍

@flash1293 flash1293 merged commit 02cba10 into elastic:master Apr 16, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Apr 16, 2020
flash1293 added a commit to flash1293/kibana that referenced this pull request Apr 16, 2020
flash1293 added a commit that referenced this pull request Apr 16, 2020
flash1293 added a commit that referenced this pull request Apr 16, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
* master: (56 commits)
  [i18n] Update CODEOWNERS (elastic#63354)
  add platform team definition of done (elastic#59993)
  [SIEM] move away from Joi for importing/exporting timeline (elastic#62125)
  Fix discover preserve url (elastic#63580)
  [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489)
  Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655)
  MIgrated index_header to react (elastic#63490)
  Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364)
  [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642)
  [Reporting] Make usable default element positions (elastic#63191)
  [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500)
  [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498)
  Split action types into own page (elastic#63516)
  [Lens] Only show copy on save for previously saved docs (elastic#63535)
  Update README.md (elastic#63622)
  Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554)
  Add uptime CODEOWNER entries. (elastic#63616)
  [ML] Extract apiDoc params from the schema definitions (elastic#62933)
  Fix alerting documentation encryption key requirement (elastic#63512)
  Fix CODEOWNERS and sass lint paths (elastic#63552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
3 participants