Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerting documentation encryption key requirement #63512

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

mikecote
Copy link
Contributor

Fixes #63230

In this PR, I'm indicating that all on-premises installs need to define an encryption key, not just the ones using security.

Current documentation: https://www.elastic.co/guide/en/kibana/7.7/alerting-getting-started.html#alerting-setup-prerequisites

Updated documentation:
Screen Shot 2020-04-14 at 3 12 31 PM

@mikecote mikecote added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Apr 14, 2020
@mikecote mikecote self-assigned this Apr 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor Author

@gchaps if you wanted to give me a 👍 on the copy for the updated docs (see below). I repeated the "If you are using an on-premises Elastic Stack deployment" section twice compared to before.

Screenshot:

Screen Shot 2020-04-14 at 3 12 31 PM

docs/user/alerting/index.asciidoc Outdated Show resolved Hide resolved
docs/user/alerting/index.asciidoc Outdated Show resolved Hide resolved
mikecote and others added 2 commits April 15, 2020 08:58
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
@mikecote
Copy link
Contributor Author

@gchaps thank you for your feedback. I recall you are also verifying if "on-premises" is the proper terminology, I will wait for another review :-)

Docs with latest changes:
Screen Shot 2020-04-15 at 9 04 53 AM

@mikecote mikecote requested a review from gchaps April 15, 2020 13:06
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that "on-premises" is the correct terminology.

@mikecote mikecote merged commit e44cf28 into elastic:master Apr 15, 2020
mikecote added a commit to mikecote/kibana that referenced this pull request Apr 15, 2020
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
mikecote added a commit to mikecote/kibana that referenced this pull request Apr 15, 2020
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
wayneseymour pushed a commit that referenced this pull request Apr 15, 2020
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
mikecote added a commit that referenced this pull request Apr 15, 2020
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
mikecote added a commit that referenced this pull request Apr 15, 2020
* Fix documentation to indicate encryption key config required regardless if security is used or not

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

* Update docs/user/alerting/index.asciidoc

Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>

Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 17, 2020
* master: (56 commits)
  [i18n] Update CODEOWNERS (elastic#63354)
  add platform team definition of done (elastic#59993)
  [SIEM] move away from Joi for importing/exporting timeline (elastic#62125)
  Fix discover preserve url (elastic#63580)
  [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489)
  Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655)
  MIgrated index_header to react (elastic#63490)
  Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364)
  [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642)
  [Reporting] Make usable default element positions (elastic#63191)
  [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500)
  [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498)
  Split action types into own page (elastic#63516)
  [Lens] Only show copy on save for previously saved docs (elastic#63535)
  Update README.md (elastic#63622)
  Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554)
  Add uptime CODEOWNER entries. (elastic#63616)
  [ML] Extract apiDoc params from the schema definitions (elastic#62933)
  Fix alerting documentation encryption key requirement (elastic#63512)
  Fix CODEOWNERS and sass lint paths (elastic#63552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: Encryption key requirement correction
3 participants