Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drilldowns] Fix back button by removing panels from url in dashboard in view mode #62415

Merged
merged 4 commits into from
Apr 18, 2020

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Apr 3, 2020

Summary

fixes #61596 by removing .panels from URL in view mode

Now when you navigate to one of those large sample dashboard - back button should navigate you back to listing page from the first attempt. The idea is that it will work for back button between dashboards using drilldowns

Dev docs

In dashboard in view mode .panels are no longer synced with the URL

@Dosant Dosant force-pushed the dev/remove-panels-from-url branch from 4f22a37 to 5244c6f Compare April 12, 2020 18:07
@Dosant Dosant changed the title [wip] POC: remove panels from url in dashboard in view mode [Drilldowns] Fix back button by removing panels from url in dashboard in view mode Apr 12, 2020
@Dosant Dosant added Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns Team:AppArch labels Apr 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@Dosant Dosant added v7.8.0 v8.0.0 release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. labels Apr 12, 2020
@Dosant Dosant marked this pull request as ready for review April 14, 2020 08:52
@Dosant Dosant requested a review from a team April 14, 2020 08:52
@Dosant Dosant requested a review from a team as a code owner April 14, 2020 08:52
Copy link
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review, tested in chrome

x-pack/test/functional/apps/maps/embeddable/dashboard.js Outdated Show resolved Hide resolved
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this in Chrome 80 on Mac OS, works great 🙌 Special thanks for adding a functional test for this.

@AlonaNadler
Copy link

Not sure if that is the right PR to comment on. I played with the PR today (I needed screenshots for ElasticON :) ) It looks very good 👍, back button worked, no esaggs errors, very exciting !!
A small comment, inside drill down the two switches should be on by default, currently, they are off.

@Dosant Dosant mentioned this pull request Apr 15, 2020
16 tasks
Copy link
Contributor

@stacey-gammon stacey-gammon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Pulled it down and played around with it. Removed panel was persisted across page refresh. Nice shorter urls in view mode!

@Dosant
Copy link
Contributor Author

Dosant commented Apr 18, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@Dosant Dosant merged commit 73548bd into elastic:master Apr 18, 2020
@Dosant Dosant deleted the dev/remove-panels-from-url branch April 18, 2020 08:34
Dosant added a commit to Dosant/kibana that referenced this pull request Apr 18, 2020
… in view mode (elastic#62415)

* remove panels from url

* review nits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Dosant added a commit that referenced this pull request Apr 18, 2020
… in view mode (#62415) (#63923)

* remove panels from url

* review nits

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 20, 2020
…bana into ingest-node-pipelines/privileges

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (126 commits)
  [SEARCH] Cleanup fetch soon (elastic#63320)
  skip flaky suite (elastic#58692)
  [Uptime] Refresh index and also show more info to user regardi… (elastic#62606)
  [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415)
  [platform] serve plugins from /bundles/plugin:${id}
  [Alerting] Documentation for how to pre-configure connectors. (elastic#63807)
  skip flaky suite (elastic#63621)
  Revert "skip flaky suite (elastic#63747)"
  skip flaky suite (elastic#63747)
  [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717)
  [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900)
  [Uptime] Add cert API request and runtime type checking (elastic#63062)
  [Lens] Allow table to scroll horizontally (elastic#63805)
  [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803)
  Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539)
  [Alerting] "Create alert" and alert list design improvements (elastic#63515)
  [Lens] Fix existence for dotted paths in _source (elastic#63752)
  Example plugins in X-Pack (elastic#63823)
  [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775)
  Endpoint: middleware receive immutable versions of state and actions (elastic#63802)
  ...
jloleysens added a commit to jloleysens/kibana that referenced this pull request Apr 20, 2020
…bana into pipeline-editor-part-mvp-2

* 'feature/ingest-node-pipelines' of github.com:elastic/kibana: (127 commits)
  [Ingest pipelines] Polish details panel and empty list (elastic#63926)
  [SEARCH] Cleanup fetch soon (elastic#63320)
  skip flaky suite (elastic#58692)
  [Uptime] Refresh index and also show more info to user regardi… (elastic#62606)
  [Drilldowns] Fix back button by removing panels from url in dashboard in view mode (elastic#62415)
  [platform] serve plugins from /bundles/plugin:${id}
  [Alerting] Documentation for how to pre-configure connectors. (elastic#63807)
  skip flaky suite (elastic#63621)
  Revert "skip flaky suite (elastic#63747)"
  skip flaky suite (elastic#63747)
  [SIEM][Detections Engine] - Update rule.lists to be rule.exceptions_list (elastic#63717)
  [SIEM] Flaky test fix: Bump find_statuses timeout (elastic#63900)
  [Uptime] Add cert API request and runtime type checking (elastic#63062)
  [Lens] Allow table to scroll horizontally (elastic#63805)
  [Metrics UI] Allow users to create alerts from the central Alerts UI (elastic#63803)
  Migrate legacy maps licensing (x-pack/tilemap) to NP (elastic#63539)
  [Alerting] "Create alert" and alert list design improvements (elastic#63515)
  [Lens] Fix existence for dotted paths in _source (elastic#63752)
  Example plugins in X-Pack (elastic#63823)
  [ML] Migrate Mocha unit tests to Jest: migrate job utils and query utils tests (elastic#63775)
  ...
@gchaps gchaps mentioned this pull request Jun 11, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Drilldowns Embeddable panel Drilldowns release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Drilldowns] Dashboard broken back button if embeddable update input during initial rendering
8 participants