Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Time to Visualize] State From Snapshot Share Not Persisted #93266

Closed
ThomThomson opened this issue Mar 2, 2021 · 2 comments
Closed

[Time to Visualize] State From Snapshot Share Not Persisted #93266

ThomThomson opened this issue Mar 2, 2021 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@ThomThomson
Copy link
Contributor

Kibana version: master

Describe the bug:
Because dashboard panels are no longer in the URL in view mode since 7.8 (#62415), refreshing the browser window when viewing a shared snapshot from a saved dashboard will restore the panels from the saved object. This might make it seem like the snapshot link isn't working - even though opening the snapshot link again will restore the proper state.

Steps to reproduce:

  1. Open an existing dashboard, and make a few changes. Do not save
  2. Share using the snapshot share feature
  3. Open the resulting link in a new browser tab. Your unsaved changes should be reflected
  4. Reload the browser
  5. The dashboard should appear in the last saved state.

Expected behavior:
When loading a URL from snapshot share, the dashboard app should save the state from the snapshot into the session storage, and treat it as unsaved state.

Suggested fix:
If it's important that the snapshot state persists over reloads, the easiest way to do so would be to ensure that any URL state gets propagated to the session storage. I would want to have #91950 complete before doing this though.

@ThomThomson ThomThomson added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:medium Medium Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:TimeToVisualize labels Mar 2, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor Author

This was fixed by #97941. State from the URL now overrides saved object state, and is loaded into the session storage so it persists over reloads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:TimeToVisualize Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants