[Discover] Suppress error when popularizeField fails #62402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dear @lizozom , before I continue here, do you think this is a valid way to go? since it contains a core API change, thx! |
|
@kertal Well, as this fix only hides the error message and changes an API, I'd say the other solution seems better. What do you think? |
@lizozom agreed, so I can see 3 quick options as alternative
|
kertal
force-pushed
the
kertal-pe-2020-04-03-suppress-popularizeField-error
branch
from
c59ff11
to
63fa09a
Compare
|
adding @streamich to discuss, who also complained about this error. @lizozom I've implemented the approach popularize takes care of saving, doesn't use the save function, what do you think? |
kertal
added
Feature:Discover
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 14, 2020
* Refactor index_patterns popularize function, so no message is displayed to the user # Conflicts: # src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
This was referenced May 14, 2020
kertal
added a commit
to kertal/kibana
that referenced
this pull request
May 14, 2020
* Refactor index_patterns popularize function, so no message is displayed to the user # Conflicts: # src/plugins/data/public/index_patterns/index_patterns/index_pattern.ts
3 tasks
kertal
added a commit
that referenced
this pull request
May 16, 2020
kertal
added a commit
that referenced
this pull request
May 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simple fix how to prevent HTTP 409 when adding fields in Discover. Every time you add or remove a field, the count value of the field is increased and the index pattern is persisted. This causes a 409 when the recent persistence hasn't finished. This PR suppresses the exception in this case. This solves the issue for the user, however technically it would be a better solution to prevent the exception like here #46566.
This is a very old problem, here's a screenshot of Kibana 6.x
Fixes #22426