Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search service] Rename async search param #61641

Merged
merged 4 commits into from
Mar 31, 2020

Conversation

lukasolson
Copy link
Member

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Fixes #61498.

The _async_search parameter wait_for_completion was renamed to wait_for_completion_timeout in elastic/elasticsearch#54198. This PR updates the name of the parameter in our search service.

@lukasolson lukasolson added review Feature:Search Querying infrastructure in Kibana v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 27, 2020
@lukasolson lukasolson requested a review from lizozom March 27, 2020 15:28
@lukasolson lukasolson requested a review from a team as a code owner March 27, 2020 15:28
@lukasolson lukasolson self-assigned this Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Jenkinsfile Outdated Show resolved Hide resolved
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rename is good, but did you intend to commit the Jeninsfile too?

@lizozom
Copy link
Contributor

lizozom commented Mar 30, 2020

@elasticmachine merge upstream

@lukasolson
Copy link
Member Author

@elasticsearch merge upstream

@lukasolson
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson merged commit c651969 into elastic:master Mar 31, 2020
lukasolson added a commit to lukasolson/kibana that referenced this pull request Mar 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson added a commit to lukasolson/kibana that referenced this pull request Mar 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson added a commit that referenced this pull request Mar 31, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
lukasolson added a commit that referenced this pull request Apr 1, 2020
* Rename async search params (#61641)

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Remove polling delay

* Fix merge issue

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Co-authored-by: Liza Katz <lizka.k@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Search service] Update _async_search parameter names
4 participants