Async search: rename REST parameters

[javanna]

This commit renames wait_for_completion to wait_for_completion_timeout in submit async search and get async search.
Also it renames clean_on_completion to keep_on_completion and turns around its behaviour.

Closes #54069

[elasticmachine]

Pinging @elastic/es-search (:Search/Search)

[bpintea]

7.7 has been FFrozen, can the v7.7.0 label be removed?

[javanna]

@Mpdreamz can correct me if I am wrong, but I think that this a blocker for the language clients. As far as I understand wait_for_completion is expected to be a boolean like in other API and breaks some of the clients, which is why it was decided to rename it.

[bpintea]

Thanks, @javanna!

@Mpdreamz can correct me if I am wrong, but I think that this a blocker for the language clients.

@jpountz May I update the list of blocking issues to include this one?

[Mpdreamz]

It won't break the clients (unless it was an enum) but these type of changes are incredibly hard to patch after a release. Since this was discussed and agreed upon by a large group on the issueI would vote to raise it as blocker so that it can go in the next bc. Similar to #54196

[jpountz]

+1 to merge to 7.7. I replaced the >enhancement label with >non-issue since async search has not been released yet.

[jimczi]

I left two comments, LGTM otherwise

[javanna]

heads up @lukasolson you will have to rename waitForCompletion to waitForCompletionTimeout in your code. I believe Kibana is not using cleanOnCompletion hence no change needed there.

[lizozom]

@lukasolson @javanna was this backported to 7.7?

[javanna]

@lizozom yes it was, see 2814226

[lizozom]

@javanna I'm asking, because backporting the kibana change to 7.7 fails in testing, while the 7.x and the 8.0 branches were working and merged

elastic/kibana#61917

[lizozom]

@javanna I think I might have found the issue. Lets see how the build goes!

[javanna]

@lizozom I see, let me know if I can do anything to help.