Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remote clusters] Add cloud-specific logic to remote clusters #61639

Conversation

alisonelizabeth
Copy link
Contributor

@alisonelizabeth alisonelizabeth commented Mar 27, 2020

Fixes #61503

Changes include:

  • [Cloud only] Server name is a required field
  • [Cloud only] Default mode is "proxy"
  • [Cloud only] Info callout added under the proxy mode switch
  • [Cloud only] When editing a v1 remote cluster, a default server name will be created for the user.
  • Fixed a bug related to the schema validation on update + added a test to guard against this scenario (64226f8).

Screen Shot 2020-03-27 at 11 18 49 AM

How to test

To simulate a cloud environment, you can enable the cloud plugin in your kibana.dev.yml settings:

xpack.cloud.enabled: true
xpack.cloud.id: 'foo'

@alisonelizabeth alisonelizabeth added Feature:CCR and Remote Clusters v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v7.8.0 labels Mar 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@alisonelizabeth alisonelizabeth marked this pull request as ready for review March 27, 2020 15:34
@alisonelizabeth
Copy link
Contributor Author

/cc @juliocamarero

@juliocamarero
Copy link

Thanks a ton @alisonelizabeth

@cristina-eleonora, could you please confirm the info callout makes sense to you?
You can find the proxy address and server name of your cluster in the Security section of your deployment.

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, code LGTM! Thanks for the copious comments and for adding tests.

@juliocamarero Are there use cases for a Cloud user to use the non-proxy mode?

@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

1 similar comment
@alisonelizabeth
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:CCR and Remote Clusters NeededFor:Cloud release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Remote Clusters in Kibana easier to configure for Cloud Users
5 participants