Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[share url] fixes embed links to re-add qs parameter #5900

Merged
merged 1 commit into from
Jan 13, 2016
Merged

[share url] fixes embed links to re-add qs parameter #5900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/ui/public/share/directives/share_object_url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,11 @@ app.directive('shareObjectUrl', function (Private, Notifier) {
};

$scope.getUrl = function () {
return $location.absUrl();
let url = $location.absUrl();
if ($scope.shareAsEmbed) {
url = url.replace('?', '?embed=true&');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really isn't how we should be handling this. This fails when there isn't a query string and when there is a query string before the hash. This should instead use require('url').parse and require('url').format.

}
return url;
};

$scope.$watch('getUrl()', updateUrl);
Expand Down