[share url] fixes embed links to re-add qs parameter #5900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $location.absUrl(); | ||
| let url = $location.absUrl(); | ||
| if ($scope.shareAsEmbed) { | ||
| url = url.replace('?', '?embed=true&'); |
There was a problem hiding this comment.
This really isn't how we should be handling this. This fails when there isn't a query string and when there is a query string before the hash. This should instead use require('url').parse and require('url').format.
|
@spalger This is how it was being handled before the rework. |
|
LGTM I tested Jim's fix |
spalger
added a commit
that referenced
this pull request
Jan 13, 2016
[share url] fixes embed links to re-add qs parameter
|
@BigFunger Where else was this merged? I don't see 5.0.0 or 4.5.0 on this pull? There's a user noting this still occurs: #5915 |
|
I don't believe this was backported, though the original issue was marked as a blocker for 4.4.0. |
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 23, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 23, 2016
elasticsearch-bot
pushed a commit
that referenced
this pull request
Jan 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5897
Re-adds the embed querystring parameter when generating embed code