Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps][Telemetry] Migrate Maps telemetry to NP #55055

Merged
merged 15 commits into from
Feb 19, 2020
Merged

[Maps][Telemetry] Migrate Maps telemetry to NP #55055

merged 15 commits into from
Feb 19, 2020

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Jan 16, 2020 •
edited
Loading

Summary

Migrates Maps telemetry to NP and typescriptifies a few files.

Testing

The easiest way to test this locally is to:

  1. Start Kibana and check the stats endpoint: http://localhost:5601/<your prepended basepath if in dev>/api/stats?extended=true
  2. In a separate tab, go to the Maps app, create a map with 1 or 2 layers and save it
  3. Go back to the stats endpoint tab and refresh. maps_telemetry > maps_total_count should have increased by one. Depending on what other maps you have saved, the other metrics with min, max, avg will likely also have changed

image

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@kindsun kindsun added v7.7.0 and removed v7.6.0 labels Jan 22, 2020
@kindsun kindsun marked this pull request as ready for review February 6, 2020 16:30
@kindsun kindsun requested a review from a team as a code owner February 6, 2020 16:30
@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Feb 6, 2020
@elasticmachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 6, 2020
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Bamieh
Bamieh approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bamieh
Copy link
Member

Bamieh commented Feb 10, 2020

@elasticmachine merge upstream

thomasneirynck
thomasneirynck reviewed Feb 12, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @aaronjcaldwell

Most comments are wrt adding types for that introduction of the TypeScript module.

x-pack/legacy/plugins/maps/index.js Outdated Show resolved Hide resolved
x-pack/legacy/plugins/maps/server/maps_telemetry/collectors/register.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts Outdated Show resolved Hide resolved
thomasneirynck
thomasneirynck approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! Thanks for making the effort and typing all the interaction points.

Some minor suggestion wrt organizing the definitions.

x-pack/legacy/plugins/maps/common/descriptor_types.d.ts Outdated Show resolved Hide resolved
x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.ts Outdated Show resolved Hide resolved
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kindsun kindsun merged commit ef15653 into elastic:master Feb 19, 2020
@kindsun kindsun mentioned this pull request Feb 19, 2020
Merged
kindsun pushed a commit to kindsun/kibana that referenced this pull request Feb 19, 2020
@elasticmachine
[Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055)
6b96036 
* Move maps telemetry to NP. Some clean-up, some ts conversion

* Update naming & org to be more in-line with guidelines

* Get TELEMETRY_TYPE from constants

* Ignore ts error importing from js file

* Set original array type passed into the function to array of ILayerTypeCount. Set return type on reduce function

* Remove unneeded 'any' types where used. Add in interfaces for map & index pattern saved objects

* Review feedback. Add layer, source, map saved object types and use

* Review feedback. Updates based on type check

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kindsun pushed a commit that referenced this pull request Feb 19, 2020
@elasticmachine
[Maps][Telemetry] Migrate Maps telemetry to NP (#55055) (#58052)
39d030b 
* Move maps telemetry to NP. Some clean-up, some ts conversion

* Update naming & org to be more in-line with guidelines

* Get TELEMETRY_TYPE from constants

* Ignore ts error importing from js file

* Set original array type passed into the function to array of ILayerTypeCount. Set return type on reduce function

* Remove unneeded 'any' types where used. Add in interfaces for map & index pattern saved objects

* Review feedback. Add layer, source, map saved object types and use

* Review feedback. Updates based on type check

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 20, 2020
@mbondyra
Merge branch 'master' into IS-27405_improve-advanced-settings-save
0c3e567 
* master: (136 commits)
  [Visualize] Remove legacy appState in visualize (elastic#57330)
  Use static time for tsvb rollup test (elastic#57701)
  [SIEM] Fix ResizeObserver polyfill (elastic#58046)
  [SIEM][Detection Engine] Fixes return codes where some were rule_id instead of id
  skip flaky suite (elastic#56816)
  skip flaky suite (elastic#58059)
  skip flaky suite (elastic#45348)
  migrates notification server routes to NP (elastic#57906)
  Moved all of the show/hide toggles outside of ordered lists. (elastic#57163)
  [APM] NP Migration - Moves plugin server files out of legacy (elastic#57532)
  [Maps][Telemetry] Migrate Maps telemetry to NP (elastic#55055)
  Embeddable add panel examples (elastic#57319)
  Fix useRequest to support query change (elastic#57723)
  Allow custom paths in plugin generator (elastic#57766)
  [SIEM][Case] Merge header components (elastic#57816)
  [ML] New Platform server shim: update job audit messages routes (elastic#57925)
  [kbn/optimizer] emit success event from reducer when all bundles cached (elastic#57945)
  [APM] Don’t include UI filters when fetching a specific transaction (elastic#57934)
  Upgrade yargs (elastic#57720)
  skip flaky suite (elastic#57762) (elastic#57997) (elastic#57998)
  ...

# Conflicts:
#	src/plugins/advanced_settings/public/management_app/components/field/__snapshots__/field.test.tsx.snap
#	src/plugins/advanced_settings/public/management_app/components/field/field.tsx
#	x-pack/plugins/translations/translations/ja-JP.json
#	x-pack/plugins/translations/translations/zh-CN.json
@thomasneirynck thomasneirynck mentioned this pull request May 29, 2020
Closed
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:NP Migration Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kindsun @elasticmachine @Bamieh @kibanamachine @thomasneirynck