Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] Add scroll into view to avoid tooltip overlap (#47106) #47202

Merged
merged 2 commits into from
Oct 4, 2019
Merged

[7.x] Add scroll into view to avoid tooltip overlap (#47106) #47202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ed5777
Add scroll into view to avoid tooltip overlap (#47106)
markov00 Oct 3, 2019
c3db798
Merge branch '7.x' into backport/7.x/pr-47106
elasticmachine Oct 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/functional/apps/visualize/_vertical_bar_chart.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,7 @@ export default function ({ getService, getPageObjects }) {
});
});

// FLAKY: https://github.com/elastic/kibana/issues/45105
describe.skip('vertical bar with multiple splits', function () {
describe('vertical bar with multiple splits', function () {
before(initBarChart);

it('should show correct series', async function () {
Expand All @@ -305,6 +304,8 @@ export default function ({ getService, getPageObjects }) {
});

it('should show correct series when disabling first agg', async function () {
// this will avoid issues with the play tooltip covering the disable agg button
await PageObjects.visualize.scrollSubjectIntoView('metricsAggGroup');
await PageObjects.visualize.toggleDisabledAgg(3);
await PageObjects.visualize.clickGo();

Expand Down
5 changes: 5 additions & 0 deletions test/functional/page_objects/visualize_page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,6 +1259,11 @@ export function VisualizePageProvider({ getService, getPageObjects, updateBaseli
const inputMax = await control.findByCssSelector('[name$="maxValue"]');
await inputMax.type(max);
}

async scrollSubjectIntoView(subject) {
const element = await testSubjects.find(subject);
await element.scrollIntoViewIfNecessary();
}
}

return new VisualizePage();
Expand Down