Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Add scroll into view to avoid tooltip overlap (#47106) #47202

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

markov00
Copy link
Member

@markov00 markov00 commented Oct 3, 2019

Backports the following commits to 7.x:

The current angular implementation of the tooltip, applied to the Apply button of the visualize editor, suffer from missing the mouseleave event in some cases. This cause the tooltip to remain open in some cases halting the test from clicking the underlying button.
The tooltip implementation will be soon replaced by EUI, so on this PR we are only unskipping the test and scrolling the visualize editor sidebar to avoid this overlap.
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 3, 2019

💔 Build Failed

13:36:08  ERROR: [Google Cloud Storage Plugin] No artifacts found matching pattern: target/kibana-*

@markov00
Copy link
Member Author

markov00 commented Oct 3, 2019

jenkins test this please

@elasticmachine
Copy link
Contributor

💔 Build Failed

@markov00
Copy link
Member Author

markov00 commented Oct 3, 2019

@elasticmachine update branch

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@markov00 markov00 merged commit 323165b into elastic:7.x Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants