Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] allow embeddables to hide filtering controls #43703

Merged
merged 2 commits into from
Aug 21, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Aug 21, 2019

fixes #43644

Also adds some documentation on map embeddable

cc @spong

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 labels Aug 21, 2019
@nreese nreese requested a review from nickpeihl August 21, 2019 17:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I tested this by adding hideFilterActions: true to the Global Flights Dashboard saved object. The filter actions button disappeared. Nice!

@nreese nreese merged commit 0d4e979 into elastic:master Aug 21, 2019
nreese added a commit to nreese/kibana that referenced this pull request Aug 21, 2019
* [Maps] allow embeddables to hide filtering controls

* fix typos in embeddable docs
nreese added a commit that referenced this pull request Aug 21, 2019
* [Maps] allow embeddables to hide filtering controls

* fix typos in embeddable docs
@bhavyarm
Copy link
Contributor

bhavyarm commented Sep 5, 2019

@nreese @nickpeihl How do I test this? Do I need to make code modifications or in kibana.yml? Thanks!

@nreese
Copy link
Contributor Author

nreese commented Sep 6, 2019

How do I test this?

This is an internal change that can be used by embeddable containers to disable filtering in the map. There is no way to enable this in the UI. It was put in place so SIEM could disable filters. In the end, SIEM was able to support filters.

@bhavyarm
Copy link
Contributor

bhavyarm commented Sep 6, 2019

@nreese thank you very much!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] [Embeddables] Provide ability to disable filtering controls within map
4 participants