Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the aria-expanded logic #3474

Merged
merged 1 commit into from
Mar 27, 2015
Merged

Fix the aria-expanded logic #3474

merged 1 commit into from
Mar 27, 2015

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 27, 2015

Fixes #3473

@spalger spalger changed the title restore the aria-expanded logic in a way that actually works Fix the aria-expanded logic Mar 27, 2015
@w33ble
Copy link
Contributor

w33ble commented Mar 27, 2015

Pushing the logic into configTemplate, nice. Creating an expanded directive later on might be handy, but this LGTM. 🍇

w33ble added a commit that referenced this pull request Mar 27, 2015
@w33ble
Merge pull request #3474 from spalger/fix/3473
0d45b70 
Fix the aria-expanded logic
@w33ble w33ble merged commit 0d45b70 into elastic:master Mar 27, 2015
@spalger spalger deleted the fix/3473 branch July 31, 2015 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@w33ble w33ble

Labels
review v4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Aria regressions
2 participants
@spalger @w33ble