Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aria regressions #3473

Closed
3 tasks done
w33ble opened this issue Mar 27, 2015 · 0 comments · Fixed by #3474
Closed
3 tasks done

Aria regressions #3473

w33ble opened this issue Mar 27, 2015 · 0 comments · Fixed by #3474
Assignees
@spalger
Labels
bug Fixes for quality problems that affect the customer experience v4.1.0

Comments

@w33ble
Copy link
Contributor

w33ble commented Mar 27, 2015

4343b19 added some regressions that were missed before it was merged. #3361 was already fixed, these need to be addressed

  • toggleAddVisualization = !toggleAddVisualization" in src/kibana/plugins/dashboard/index.html link
  • toggleSaveSearch = !toggleSaveSearch" in src/kibana/plugins/discover/index.html link
  • toggleLoadSavedSearch = !toggleLoadSavedSearch in src/kibana/plugins/discover/index.html link
@w33ble w33ble added bug Fixes for quality problems that affect the customer experience v4.1.0 labels Mar 27, 2015
@spalger spalger mentioned this issue Mar 27, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalger spalger

Labels
bug Fixes for quality problems that affect the customer experience v4.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the aria-expanded logic spalger/kibana
2 participants
@w33ble @spalger