Add Negative Axes to Line, Bar, and Area Charts/Fix Pie Issues with 0 values #2680
Conversation
… into fix/elastic#1962 Conflicts: src/kibana/components/vislib/visualizations/column_chart.js
|
If all values on the chart are negative should the Y-axis start at 0? Seems like it?
|
|
Line chart doesn't see to work anymore: |
|
Area charts, same issue as bar charts: |
|
This also seems to kill event handlers on area charts |
|
@rashidkpc I'll look into the event handling for area charts as well as that issue with line charts. As far as the y-axis defaulting to zero when all values are positive or negative. We plan on adding an option that allows users to choose to start the y-axis at zero or the min of the data set. We have also added an option for someone to set the min and max for the y-axis, although we need to get the UI in for it. |
|
@rashidkpc the last commit fixed the issue with line charts, but I can't seem to recreate the event handler issues with area charts. |
Conflicts: src/kibana/components/vislib/lib/data.js src/kibana/components/vislib/lib/handler/types/column.js src/kibana/components/vislib/lib/handler/types/line.js
Merged master and bucketOnExpression
Conflicts: src/kibana/components/vislib/lib/data.js
Working negative y-axes values
stormpython
changed the title
Add Negative Axes to Line, Bar, and Area Charts/Fix Pie Issues with 0 values
Closes #1962.
Closes #2863.
This pull request adds the ability for negative data values in Kibana. Line, area, and bar charts can now display values in two directions, a negative and positive direction.
Fixes issues with pie chart when pies are returned with 0 values. If all values are zero, an error messaged is displayed which informs the user that no pie can be rendered due to the 0 values. Additionally, fixes the issue where no pie chart is rendered when any outer node is zero.
D3 builds pies from the outside in, and when the outer node is 0, it does not traverse the parent, it simply does not draw the relevant slices. So, values with zero needed to be filtered out so that pie slices could be rendered.