Working negative y-axes values #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
January 30, 2015 00:29
… caching calculations
… bucketOnExpression
Conflicts: src/kibana/components/agg_types/buckets/terms.js
… bucketOnExpression
Fix console error for visualizations without spy
pluralize hit - closes elastic#2877
[vislib/dispatch] only start brushing with a left-click
Conflicts: src/kibana/components/vislib/lib/data.js src/kibana/components/vislib/lib/handler/types/column.js src/kibana/components/vislib/lib/handler/types/line.js
Merged master and bucketOnExpression
Conflicts: src/kibana/components/vislib/lib/data.js
stormpython
added a commit
that referenced
this pull request
Feb 5, 2015
Working negative y-axes values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least I hope...
Spencer create a PR against this that included is bucketOnExpression changes (the endzone stuff)
I merged master as well - I think I did it correctly, but you should definitely check my work there. I believe the part I wasn't sure about was dealing with
getYMinValue, or something else with the Y values...