-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update puppeteer to 24.1.1 #208477
Merged
+96
−99
Merged
update puppeteer to 24.1.1 #208477
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5764b0f
update puppeteer to 24.1.1
pmuellr b0421e5
[CI] Auto-commit changed files from 'node scripts/notice'
kibanamachine f2dc61d
[CI] Auto-commit changed files from 'node scripts/yarn_deduplicate'
kibanamachine c7902c4
hacks to work around type errors from zod
pmuellr e880339
use Win revision instead of Win_x64
pmuellr e74df26
de-de-dupe zod, revert type change hacks
pmuellr 2d6d988
Merge branch 'main' into puppeteer-24.1.1
pmuellr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,10 @@ export const assertPickVersionIsTarget = ({ requestBody, ruleId }: AssertRuleTyp | |
pickVersions.push(rulePayload?.pick_version ?? requestBody.pick_version ?? 'MERGED'); | ||
|
||
if (rulePayload?.fields) { | ||
const fieldPickValues = Object.values(rulePayload?.fields).map((field) => field.pick_version); | ||
const fieldPickValues = Object.values(rulePayload?.fields).map( | ||
// eslint-disable-next-line @typescript-eslint/no-explicit-any | ||
(field) => (field as any).pick_version | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we can accept this change. |
||
); | ||
pickVersions.push(...fieldPickValues); | ||
} | ||
} else { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this to our attention, @pmuellr!
What seems to be happening is
puppeteer
upgrade also bumpschromium-bidi
, which in turn bumpszod
to3.24.1
(instead of3.23.8
).There's a TS type change in
zod
3.24.1
, which causes aType instantiation is excessively deep and possibly infinite
TS error forRuleUpgradeSpecifier
. This makes the type to be computed incorrectly, even if we suppress the error.The type becomes
![Schermafbeelding 2025-02-01 om 16 22 42](https://private-user-images.githubusercontent.com/15949146/408807800-d1646e04-7d59-46dc-b0a1-3bb574dbf3e2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzgzNTQsIm5iZiI6MTczOTA3ODA1NCwicGF0aCI6Ii8xNTk0OTE0Ni80MDg4MDc4MDAtZDE2NDZlMDQtN2Q1OS00NmRjLWIwYTEtM2JiNTc0ZGJmM2UyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDA1MTQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVhZWU0NDc0MDJkNzkyYjhhM2QzMDM2NjFhZDdlMjI3ODg3ODVlZjkyODk4MTU1NzBiNTZkYWUzNWE3YzVmOWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.29Oy8KUXVXM3H4ugDjUSTtXXf97nQ-7Vg_u2G2Sn9nE)
![Schermafbeelding 2025-02-01 om 16 21 33](https://private-user-images.githubusercontent.com/15949146/408807852-706e8f18-5ca4-4e16-8b3d-898504b0087c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwNzgzNTQsIm5iZiI6MTczOTA3ODA1NCwicGF0aCI6Ii8xNTk0OTE0Ni80MDg4MDc4NTItNzA2ZThmMTgtNWNhNC00ZTE2LThiM2QtODk4NTA0YjAwODdjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA5VDA1MTQxNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI2YWZlMjA0ODNhYjE1OGY2NWQ5NjQ2OGU1YjAwMDA4MWZmNWE0MGMwYzVlMjFlM2VmNzU5N2QzNmQ3MjJlNDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.V1ribbNC6sZwQnXpKV_kajheRsmshwnfzHwmKEBUz8M)
instead of
We really need these types to be correct, so we'll need a way to fix this without falling back to "any".
I think we can do
yarn add zod@3.23.8
to pin the version in Kibana and allow packages innode_modules
to have their ownzod
s with correct versions. Then we can unpin it once the types on the Zod side are fixed. No idea whether Zod folks are planning to do it at all, though.Otherwise, we'd need to rewrite
RuleUpgradeSpecifier
type somehow to not cause the error. But, tbh, I have no idea if this is doable.@xcrzx, since you are more familiar with Zod, what's your suggestion?