Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update puppeteer to 24.1.1 #208477

Merged
merged 7 commits into from
Feb 5, 2025
Merged

update puppeteer to 24.1.1 #208477

merged 7 commits into from
Feb 5, 2025

Conversation

pmuellr
Copy link
Member

@pmuellr pmuellr commented Jan 28, 2025

Summary

Updates puppeteer to 24.1.1

@pmuellr
Copy link
Member Author

pmuellr commented Jan 28, 2025

Like my previous attempt at upgrading puppeteer to 24.0.0, something in puppeteer has updated zod to 3.24.1, and now security solution code is failing with zod-related type errors.

I had previously tried "pinning" the zod version in the root package.json by changing the caret to a tilde, then removing it entirely and using the resolved version of zod (from before the PR - 3.23.8). The hope was the everything else in Kibana would use the existing version, and only puppeteer would use the new version. Didn't help, for some reason, yarn seems to have security solution using the new zod, which is causing type errors. I tried pinning in this PR, and it also didn't help.

I'll need @elastic/security-detection-rule-management and/or @elastic/kibana-core to help out. The errors I saw have been fixed with any hacks, in commit c7902c4 - seems like RuleUpgradeSpecifier is at least one offender ...

In the previous attempt, Patryk commented that we could use a resolutions value in the package.json to force a version, which I guess means using the previously resolved version 3.23.8 everywhere. But that means puppeteer, a package we don't maintain, would be running a back-level version, which doesn't seem right to me ...

Even if we find some tricks to get the right versions loaded by the plugins who need it, I guess this is send-ahead that upgrading to zod 3.24.1 is going to cause some problems in the future ...

@pmuellr pmuellr added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) backport:prev-major Backport to (8.x, 8.18, 8.17, 8.16) the previous major branch and other branches in development backport:version Backport to applied version labels v9.0.0 v8.18.0 v8.15.6 v7.17.28 v8.16.4 v8.17.2 labels Jan 29, 2025
@pmuellr pmuellr marked this pull request as ready for review January 29, 2025 13:12
@pmuellr pmuellr requested review from a team as code owners January 29, 2025 13:12
@pmuellr pmuellr requested a review from nikitaindik January 29, 2025 13:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@pmuellr pmuellr added ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-persist-deployment Persist project deployment indefinitely ci:project-redeploy Always create a new Cloud project labels Jan 29, 2025
Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think Response Ops review is required but LGTM anyway :)

@@ -101,6 +101,7 @@ export const RuleFieldsToUpgrade = z
.strict();

export type RuleUpgradeSpecifier = z.infer<typeof RuleUpgradeSpecifier>;
// @ts-expect-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this to our attention, @pmuellr!

What seems to be happening is puppeteer upgrade also bumps chromium-bidi, which in turn bumps zod to 3.24.1 (instead of 3.23.8).

There's a TS type change in zod 3.24.1, which causes a Type instantiation is excessively deep and possibly infinite TS error for RuleUpgradeSpecifier. This makes the type to be computed incorrectly, even if we suppress the error.

The type becomes
Scherm­afbeelding 2025-02-01 om 16 22 42
instead of
Scherm­afbeelding 2025-02-01 om 16 21 33

We really need these types to be correct, so we'll need a way to fix this without falling back to "any".

I think we can do yarn add zod@3.23.8 to pin the version in Kibana and allow packages in node_modules to have their own zods with correct versions. Then we can unpin it once the types on the Zod side are fixed. No idea whether Zod folks are planning to do it at all, though.

Otherwise, we'd need to rewrite RuleUpgradeSpecifier type somehow to not cause the error. But, tbh, I have no idea if this is doable.

@xcrzx, since you are more familiar with Zod, what's your suggestion?

@pmuellr
Copy link
Member Author

pmuellr commented Feb 5, 2025

tested locally, with a ci cloud build, and on windows via cloud vm

@pmuellr pmuellr merged commit b311acf into elastic:main Feb 5, 2025
13 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 7.17, 8.15, 8.16, 8.17, 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/13165359810

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b311acf)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b311acf)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 5, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b311acf)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.15 Backport failed because of merge conflicts
8.16 Backport failed because of merge conflicts
8.17 Backport failed because of merge conflicts
8.18
8.x
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 208477

Questions ?

Please refer to the Backport tool documentation

@pmuellr
Copy link
Member Author

pmuellr commented Feb 5, 2025

It doesn't look like there will be any more 8.15 releases, so with the backport failures, will need to manually backport:

  • 7.17
  • 8.16
  • 8.17

kibanamachine added a commit that referenced this pull request Feb 5, 2025
# Backport

This will backport the following commits from `main` to `8.18`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}}]}]
BACKPORT-->

Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co>
kibanamachine added a commit that referenced this pull request Feb 5, 2025
# Backport

This will backport the following commits from `main` to `9.0`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}}]}]
BACKPORT-->

Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co>
pmuellr added a commit to pmuellr/kibana that referenced this pull request Feb 5, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b311acf)

# Conflicts:
#	yarn.lock
kibanamachine added a commit that referenced this pull request Feb 5, 2025
# Backport

This will backport the following commits from `main` to `8.x`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}}]}]
BACKPORT-->

Co-authored-by: Patrick Mueller <patrick.mueller@elastic.co>
@pmuellr
Copy link
Member Author

pmuellr commented Feb 5, 2025

💚 All backports created successfully

Status Branch Result
8.17
8.16
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

pmuellr added a commit to pmuellr/kibana that referenced this pull request Feb 5, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit b311acf)

# Conflicts:
#	package.json
#	src/dev/yarn_deduplicate/index.ts
#	yarn.lock
pmuellr added a commit that referenced this pull request Feb 6, 2025
# Backport

This will backport the following commits from `main` to `8.17`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209898","number":209898,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209896","number":209896,"state":"OPEN"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},{"url":"https://github.com/elastic/kibana/pull/209897","number":209897,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->
pmuellr added a commit that referenced this pull request Feb 6, 2025
# Backport

This will backport the following commits from `main` to `8.16`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209898","number":209898,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209896","number":209896,"state":"OPEN"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},{"url":"https://github.com/elastic/kibana/pull/209897","number":209897,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 6, 2025
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

drewdaemon pushed a commit to drewdaemon/kibana that referenced this pull request Feb 6, 2025
## Summary

Updates puppeteer to 24.1.1

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
pmuellr added a commit that referenced this pull request Feb 7, 2025
# Backport

This will backport the following commits from `main` to `7.17`:
- [update puppeteer to 24.1.1
(#208477)](#208477)

<!--- Backport version: 9.6.4 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Patrick
Mueller","email":"patrick.mueller@elastic.co"},"sourceCommit":{"committedDate":"2025-02-05T19:46:51Z","message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Team:SharedUX","backport:all-open","ci:cloud-deploy","ci:cloud-redeploy","ci:project-deploy-elasticsearch","ci:project-persist-deployment","ci:project-redeploy","backport:version","v8.18.0","v8.15.6","v7.17.28","v8.16.4","v8.17.2","v9.1.0"],"title":"update
puppeteer to
24.1.1","number":208477,"url":"https://github.com/elastic/kibana/pull/208477","mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","7.17","8.16","8.17"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209898","number":209898,"state":"OPEN"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/209896","number":209896,"state":"OPEN"},{"branch":"8.15","label":"v8.15.6","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"7.17","label":"v7.17.28","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.4","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208477","number":208477,"mergeCommit":{"message":"update
puppeteer to 24.1.1 (#208477)\n\n## Summary\r\n\r\nUpdates puppeteer to
24.1.1\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"b311acfec43009e5879e42f5025c3f56fa0edde6"}},{"url":"https://github.com/elastic/kibana/pull/209897","number":209897,"branch":"8.x","state":"OPEN"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release backport:version Backport to applied version labels ci:cloud-deploy Create or update a Cloud deployment ci:cloud-redeploy Always create a new Cloud deployment ci:project-deploy-elasticsearch Create an Elasticsearch Serverless project ci:project-persist-deployment Persist project deployment indefinitely ci:project-redeploy Always create a new Cloud project release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v7.17.28 v8.15.6 v8.16.4 v8.17.2 v8.18.0 v8.19.0 v9.0.0 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants