Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Migrate installPackageByUpload and installCustomPackage to state machine and clean up #192438

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Sep 10, 2024

Closes #189346
Closes #189347

Summary

Final PR for part I of package lifecycle improvements.

  • Migrate both installPackageByUpload and installCustomPackage to installPackageWithStateMachine and clean up the old code. As the state machine is been working in production for two releases, I am confident in using it for the custom and upload packages without a feature flag.

Testing

  • Try installing a custom package
  • Try installing a package via upload

They should work as usual

Checklist

@criamico criamico added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 10, 2024
@criamico criamico self-assigned this Sep 10, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico marked this pull request as ready for review September 10, 2024 10:39
@criamico criamico requested a review from a team as a code owner September 10, 2024 10:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #93 / Rules Management - Prebuilt Rules - Large Prebuilt Rules Package @ess @serverless @skipInServerlessMKI install_large_prebuilt_rules_package should install a package containing 15000 prebuilt rules without crashing

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

@criamico criamico merged commit 7e52c4e into elastic:main Sep 10, 2024
31 checks passed
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Sep 10, 2024
@criamico criamico deleted the 189346_package_install_phase_I branch September 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.16.0
Projects
None yet
6 participants