Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Use new package install state machine in installPackageByUpload #189346

Closed
2 tasks
criamico opened this issue Jul 29, 2024 · 1 comment · Fixed by #192438
Closed
2 tasks

[Fleet] Use new package install state machine in installPackageByUpload #189346

criamico opened this issue Jul 29, 2024 · 1 comment · Fixed by #192438
Assignees
@criamico
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@criamico
Copy link
Contributor

criamico commented Jul 29, 2024 •
edited
Loading

Follow up of #175592.

With 8.14.0 a new state machine functionality to install packages was introduced, but it was only enabled in install by registry and put under feature flag enablePackagesStateMachine.

  • Introduce the functionality also in installPackageByUpload, similar to what we did in installPackageWitStateMachine
  • Use a new feature flag to trigger this functionality - enablePackagesStateMachine is currently enabled in production se it can be called enablePackagesStateMachineV2
@criamico criamico mentioned this issue Jul 29, 2024
Open
@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 29, 2024
@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 29, 2024
@criamico criamico changed the title [Fleet] Use new package install state machine in install by upload [Fleet] Use new package install state machine in instalPackageByUpload Jul 29, 2024
@criamico criamico changed the title [Fleet] Use new package install state machine in instalPackageByUpload [Fleet] Use new package install state machine in installPackageByUpload Jul 29, 2024
@criamico criamico self-assigned this Sep 10, 2024
@criamico criamico mentioned this issue Sep 10, 2024
Merged
2 tasks
criamico added a commit that referenced this issue Sep 10, 2024
@criamico
[Fleet] Migrate installPackageByUpload and installCustomPackage to st…
7e52c4e 
…ate machine and clean up (#192438)

Closes #189346
Closes #189347

## Summary
Final PR for part I of package lifecycle improvements. 

- Migrate both `installPackageByUpload` and `installCustomPackage` to
`installPackageWithStateMachine` and clean up the old code. As the state
machine is been working in production for two releases, I am confident
in using it for the custom and upload packages without a feature flag.

### Testing

- Try installing a custom package
- Try installing a package via upload

They should work as usual

### Checklist
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
2 participants
@elasticmachine @criamico