[Infra UI] Remove popout icon from APM Services and open as page links #161732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennypavlova
added
Team:Infra Monitoring UI - DEPRECATED
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…ot-indicate-popout-for-the-actions-in-the-host-detail-view
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
…ot-indicate-popout-for-the-actions-in-the-host-detail-view
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
jennypavlova
added
the
backport:prev-minor
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
jennypavlova
added a commit
to jennypavlova/kibana
that referenced
this pull request
Jul 14, 2023
elastic#161732) Closes elastic#161169 ## Summary This PR removes the popout icon from APM Services and open as page links Update: (`APM Services` is changed to `View APM Services`) <img width="962" alt="image" src="https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b"> ## Testing - Go to Hosts view and open the flyout (for any host) - The top right links shouldn't have a popout and should open in the same tab  (cherry picked from commit 3f0c84b) # Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
jennypavlova
added a commit
that referenced
this pull request
Jul 14, 2023
…e links (#161732) (#161974) # Backport This will backport the following commits from `main` to `8.9`: - [[Infra UI] Remove popout icon from APM Services and open as page links (#161732)](#161732) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2023-07-14T13:44:43Z","message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":161732,"url":"https://github.com/elastic/kibana/pull/161732","mergeCommit":{"message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161732","number":161732,"mergeCommit":{"message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #161169
Summary
This PR removes the popout icon from APM Services and open as page links
Update: (
APM Servicesis changed toView APM Services)Testing