[Infra UI / Hosts] Change the button to not indicate popout for the actions in the Host detail view
#161169
Comments
formgeist
added
enhancement
|
Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI) |
smith
added
bug
|
Prioritized to be fixed before 8.9.0 release. |
|
@formgeist a question about the logic here - we assumed the opening a new tab was the preferred, default action here [and the icons were therefore OK]. I have included in the designs for the new "Overview" tab links to Alerts/APM that use this icon and do open content in new tabs - my assumption was that by clicking one of these options, we would be opening a completely new user flow - I thought those links could also follow this logic - but seems the icons were there by mistake. What was here the original idea? Trying to understand the original designs so we can eventually adjust the new ones. |
|
Hey @kkurstak - thanks for the call-out here. The orginal design pre-dates me so I'm not actually sure. A few things I know users complain about are:
I can see an argument for opening this in a new tab - it would stop avoid slow Kibana load times if they want to go back/forth. At the same time, as our Infra UI Host URLs always open the exact view you had before - clicking 'back' will take you back to the same view. One thing I would say is that we can probably think about this as the same user journey - they're carrying on whatever they're doing (e.g. an investigation). Also, we want to remove any divides between parts of Observability - it should all be one seamless experience. I actually don't have a strong opinion on how to achieve this here so I'll defer to you on the best styling/UX (i.e. new tab or not)... |
|
In general, we strive to only open in a window if it's outside Kibana e.g. docs or website. The browser and routing in Kibana should be able to support the user to go back without issues (if it doesn't, we should fix it). The open in a window will reload Kibana and that's not a great experience. The user has the open of opening in a window if they want, but we cannot support the other way around (if the link opens in a new window, we're forcing that behaviour for the user). |
|
Cool - I'll take your steer on this then @formgeist / @kkurstak . I also with your logic. @kkurstak - Feel free to propose what you think is best... |
|
Ive double checked with Jenny that we can open the flyout on the same state as the user hits 'back' after going to services. Let's then stick to this logic and make sure the user goes back to where he left. This then means we'll need to adjust the icons we have for the overview flyout - we wont be redirecting to new tabs in this case. |
|
Hey @kkurstak and @formgeist, we are talking about the APM Services and Open as page links, right?
Is there anything else that should be changed? cc @roshan-elastic As this is marked as a bug do we also want to backport it to 8.9? |
|
Hey @jennypavlova - that's right. I'm sure @kkurstak will let you know if there's anything else. For the backport, I don't think it's worth the effort unless it's just clicking a button. It's really just UI aesthetics - almost an enhancement. |
|
@jennypavlova I've updated the designs in the other epics - apart from removing the icons, we'll be changing the icons and copy for the "Show all" buttons [We'll do: Show metadata --> / Show APM services --> instead)- everything explained in the epics. Also, Ive updated Figma :) |
|
Hi @kkurstak Thank you for the answer! I was asking if we want to apply this change to other links as well, can you think of other places where we want to change the links? I don't see the updated figma design ( I still see the same as in my screenshot here ) Only in one place there is a change to View APM Services (not Show APM services) 🤔 Should we go for the solution described in this issue or we want to change that further (we can always change them as part of other issues once this bug is fixed)? |
|
@kkurstak I changed the link to match the latest Figma update: |
#161732) Closes #161169 ## Summary This PR removes the popout icon from APM Services and open as page links Update: (`APM Services` is changed to `View APM Services`) <img width="962" alt="image" src="https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b"> ## Testing - Go to Hosts view and open the flyout (for any host) - The top right links shouldn't have a popout and should open in the same tab 
elastic#161732) Closes elastic#161169 ## Summary This PR removes the popout icon from APM Services and open as page links Update: (`APM Services` is changed to `View APM Services`) <img width="962" alt="image" src="https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b"> ## Testing - Go to Hosts view and open the flyout (for any host) - The top right links shouldn't have a popout and should open in the same tab  (cherry picked from commit 3f0c84b) # Conflicts: # x-pack/plugins/translations/translations/fr-FR.json # x-pack/plugins/translations/translations/ja-JP.json # x-pack/plugins/translations/translations/zh-CN.json
…e links (#161732) (#161974) # Backport This will backport the following commits from `main` to `8.9`: - [[Infra UI] Remove popout icon from APM Services and open as page links (#161732)](#161732) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2023-07-14T13:44:43Z","message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280","branchLabelMapping":{"^v8.10.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra Monitoring UI","release_note:skip","backport:prev-minor","v8.10.0"],"number":161732,"url":"https://github.com/elastic/kibana/pull/161732","mergeCommit":{"message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.10.0","labelRegex":"^v8.10.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/161732","number":161732,"mergeCommit":{"message":"[Infra UI] Remove popout icon from APM Services and open as page links (#161732)\n\nCloses #161169 \r\n\r\n## Summary\r\n\r\nThis PR removes the popout icon from APM Services and open as page links\r\n\r\nUpdate: (`APM Services` is changed to `View APM Services`)\r\n<img width=\"962\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/14139027/10909976-1367-4b48-9fdb-bff56fcf354b\">\r\n\r\n\r\n## Testing\r\n- Go to Hosts view and open the flyout (for any host)\r\n- The top right links shouldn't have a popout and should open in the\r\nsame tab\r\n\r\n","sha":"3f0c84b564325e00388134b282013160e7dbd280"}}]}] BACKPORT-->
|
Thank you! |
Kibana version:
main/ 8.10.0Description of the problem including expected versus actual behavior:
The current actions from the Host detail view show that they open in a new window, but this isn't what's happening (and not what should be happening). We should remove the
popoutorexternalprop from the action buttonsThe text was updated successfully, but these errors were encountered: