[APM] Add index.fast_refresh to .apm-custom-link
#159674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
2 tasks
sorenlouv
commented
Jun 14, 2023
sorenlouv
added
the
release_note:skip
MiriamAparicio
force-pushed
the
add-index-fast-refresh
branch
from
9999d1a
to
b324347
Compare
| }) { | ||
| return client.indices.create({ | ||
| return await client.indices.create({ |
There was a problem hiding this comment.
Why do we need to await here instead of just passing the promise?
There was a problem hiding this comment.
Not sure if that was the intention here, but awaiting a promise inside of a function can be useful for debugging, as it ensures the function shows up in the stacktrace. Here's some explanation: goldbergyoni/nodebestpractices#737
|
Pinging @elastic/apm-ui (Team:APM) |
dgieselaar
approved these changes
Jul 12, 2023
pgayvallet
approved these changes
Jul 12, 2023
legrego
approved these changes
Jul 12, 2023
sorenlouv
commented
Jul 13, 2023
x-pack/plugins/apm/server/routes/settings/custom_link/create_custom_link_index.ts
Show resolved
Hide resolved
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Async chunks
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
approved these changes
Jul 14, 2023
kibanamachine
added
v8.10.0
backport:skip
MiriamAparicio
added a commit
that referenced
this pull request
Aug 4, 2023
This reverts commit efdc760.
MiriamAparicio
added a commit
that referenced
this pull request
Aug 8, 2023
Reverts #159674 The Elasticsearch team has changed their guidance about `fast_refresh` and want this setting to be applied from within an Elasticsearch plugin
bryce-b
pushed a commit
to bryce-b/kibana
that referenced
this pull request
Aug 9, 2023
…163142) Reverts elastic#159674 The Elasticsearch team has changed their guidance about `fast_refresh` and want this setting to be applied from within an Elasticsearch plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #155330
Adds
index.fast_refreshto.apm-custom-linkin order to ensure fast index refreshes on serverless (1 second periodic refreshes instead of 5 second which is the new default on serverless).This is pending on Elasticsearch adding support for
index.fast_refresh(elastic/elasticsearch#96660)