Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fast_refresh setting for stateless #96660

Merged

Conversation

kingherc
Copy link
Contributor

@kingherc kingherc commented Jun 7, 2023

Introduces fast_refresh setting for indices, which is only allowed on stateless nodes.

Relates ES-6234

@kingherc kingherc added >non-issue :Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) Team:Distributed Meta label for distributed team labels Jun 7, 2023
@kingherc kingherc self-assigned this Jun 7, 2023
@kingherc kingherc force-pushed the non-issue/ES-6234-move-fast-refresh branch from e45f4e5 to f70e20e Compare June 7, 2023 15:49
@kingherc kingherc marked this pull request as ready for review June 7, 2023 17:21
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@kingherc
Copy link
Contributor Author

kingherc commented Jun 7, 2023

@Tim-Brooks should we also change the default refresh interval value here as well?

@Tim-Brooks
Copy link
Contributor

should we also change the default refresh interval value here as well?

I don't think that is necessarily straightforward to do. Maybe we can branch on node type but it is messy to make an index setting rely on a node setting. We should have this default be it's own discussion.

Copy link
Contributor

@Tim-Brooks Tim-Brooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Please add an actual PR description when merging including the fact that this setting is only allowed with stateless node types.

For example:

@kingherc kingherc merged commit 92df5ac into elastic:main Jun 8, 2023
@kingherc kingherc deleted the non-issue/ES-6234-move-fast-refresh branch June 8, 2023 07:57
MiriamAparicio added a commit to elastic/kibana that referenced this pull request Jul 14, 2023
Closes: #155330

Adds `index.fast_refresh` to `.apm-custom-link` in order to ensure fast
index refreshes on serverless (1 second periodic refreshes instead of 5
second which is the new default on serverless).

This is pending on Elasticsearch adding support for `index.fast_refresh`
(elastic/elasticsearch#96660)

---------

Co-authored-by: miriam.aparicio <miriam.aparicio@gmail.com>
Co-authored-by: Miriam <31922082+MiriamAparicio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Allocation All issues relating to the decision making around placing a shard (both master logic & on the nodes) >non-issue Team:Distributed Meta label for distributed team v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants