Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search][Behavioral Analytics] Update formulas #156704

Merged
merged 2 commits into from
May 4, 2023

Conversation

yansavitski
Copy link
Contributor

Fixing formula issues for explore tables

  • ✔️ Remove event_type filter for location table
  • ✔️ Aggrate by page.url.origin for top clicked table

@yansavitski yansavitski added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:EnterpriseSearch v8.8.0 labels May 4, 2023
@yansavitski yansavitski requested a review from a team May 4, 2023 15:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -34.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yansavitski yansavitski merged commit 75ace9c into elastic:main May 4, 2023
@yansavitski yansavitski deleted the ba-fix-formulas branch May 4, 2023 20:00
jloleysens added a commit that referenced this pull request May 5, 2023
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
@sphilipse
Copy link
Member

Same question here: why is this tagged with v8.8.0 but also backport:skip? Do you want this backported to 8.8 or not?

@yansavitski yansavitski removed the backport:skip This commit does not require backporting label May 5, 2023
yansavitski added a commit to yansavitski/kibana that referenced this pull request May 8, 2023
…6704)

Fixing formula issues for explore tables

- ✔️ Remove event_type filter for location table
- ✔️ Aggrate by page.url.origin for top clicked table

(cherry picked from commit 75ace9c)
@yansavitski
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

yansavitski added a commit that referenced this pull request May 8, 2023
) (#156978)

# Backport

This will backport the following commits from `main` to `8.8`:
- [[Enterprise Search][Behavioral Analytics] Update formulas
(#156704)](#156704)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yan
Savitski","email":"yan.savitski@elastic.co"},"sourceCommit":{"committedDate":"2023-05-04T19:06:09Z","message":"[Enterprise
Search][Behavioral Analytics] Update formulas (#156704)\n\nFixing
formula issues for explore tables\r\n\r\n- ✔️ Remove event_type filter
for location table\r\n- ✔️ Aggrate by page.url.origin for top clicked
table","sha":"75ace9c9e90e76ccc21426db437be77dd3d01c87","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:EnterpriseSearch","v8.8.0","v8.9.0"],"number":156704,"url":"https://github.com/elastic/kibana/pull/156704","mergeCommit":{"message":"[Enterprise
Search][Behavioral Analytics] Update formulas (#156704)\n\nFixing
formula issues for explore tables\r\n\r\n- ✔️ Remove event_type filter
for location table\r\n- ✔️ Aggrate by page.url.origin for top clicked
table","sha":"75ace9c9e90e76ccc21426db437be77dd3d01c87"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/156704","number":156704,"mergeCommit":{"message":"[Enterprise
Search][Behavioral Analytics] Update formulas (#156704)\n\nFixing
formula issues for explore tables\r\n\r\n- ✔️ Remove event_type filter
for location table\r\n- ✔️ Aggrate by page.url.origin for top clicked
table","sha":"75ace9c9e90e76ccc21426db437be77dd3d01c87"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 v8.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants