Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RAM] Docs for slack improvements #153885

Merged
merged 32 commits into from
May 5, 2023
Merged

[RAM] Docs for slack improvements #153885

merged 32 commits into from
May 5, 2023

Conversation

guskovaue
Copy link
Contributor

@guskovaue guskovaue commented Mar 28, 2023 •
edited by kibanamachine
Loading

guskovaue and others added 14 commits March 8, 2023 12:27
@guskovaue
add test which create auto snapshots for slack connector
3f88e68
@guskovaue
add preconfigured web api connector section
8d7ee38
@guskovaue
create Configure a Slack account with Web AP
8815a62
@guskovaue
Merge branch 'main' into RAM-152880-change-docs-for-slack-improvements
81777d7
@guskovaue
addition to previous comment
64f998b
@guskovaue
attempt to write openapi
ef3df61
@lcawl
[DOCS] Add enumerated data type in update_connector_request_slack.yaml
c6fbfea
@lcawl
[DOCS] Uncomment update_connector_request_slack.yaml
d42e63f
@lcawl
[DOCS] Generate API doc output
b8b2397
@guskovaue
Merge branch 'main' into RAM-152880-change-docs-for-slack-improvements
005360e
@kibanamachine
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
c1d1fc9 
…-fix'
@guskovaue
write openapi docs
156ee4c
@guskovaue
Merge branch 'RAM-152880-change-docs-for-slack-improvements' of githu…
bf55d9e 
…b.com:guskovaue/kibana into RAM-152880-change-docs-for-slack-improvements
@guskovaue
delete old file
947291f
@guskovaue guskovaue force-pushed the RAM-152880-change-docs-for-slack-improvements branch from 4ca3deb to 947291f Compare March 29, 2023 12:17
@guskovaue guskovaue self-assigned this Apr 27, 2023
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / dashboard panel titles by reference unlinking a by reference panel with a custom title will keep the current title

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
stackConnectors 29.9KB 29.9KB -29.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
securitySolution 398 401 +3
total +5

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
securitySolution 478 481 +3
total +5

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @guskovaue

@lcawl lcawl added docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.9.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) ui-copy Review of UI copy with docs team is recommended release_note:skip Skip the PR/issue when compiling release notes labels May 3, 2023
@guskovaue guskovaue marked this pull request as ready for review May 4, 2023 15:09
@guskovaue guskovaue requested a review from a team as a code owner May 4, 2023 15:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

XavierM
XavierM approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks correct to me but I will differ to @lcawl before we merged this PR

lcawl
lcawl approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guskovaue guskovaue merged commit 4dd6d1a into elastic:main May 5, 2023
@kibanamachine kibanamachine mentioned this pull request May 5, 2023
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 5, 2023
@guskovaue
[RAM] Docs for slack improvements (elastic#153885)
ff73906 
## Summary

Docs for new Slack connector

### Preview

https://kibana_153885.docs-preview.app.elstc.co/guide/en/kibana/master/slack-action-type.html

---------

Co-authored-by: lcawl <lcawley@elastic.co>
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 4dd6d1a)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.8

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jloleysens added a commit that referenced this pull request May 5, 2023
@jloleysens
Merge branch 'main' into versioned-router-and-oas
630343b 
* main: (153 commits)
  [Security Solution] {{state.signals_count}} Object not working (#156472) (#156707)
  [Synthetics] refresh data on visualization scrubbing (#156777)
  [RAM] Docs for slack improvements (#153885)
  [RAM] Alert search bar only KQL (#155947)
  [ML] Functional tests - stabilize export job tests (#156586)
  [Saved Search] Update saved search schema to allow empty `sort` arrays (#156769)
  [ML] Rename `curated` model type to `elastic` (#156684)
  [Discover] Enable sharing for text based languages (#156652)
  [api-docs] 2023-05-05 Daily api_docs build (#156781)
  Upgrade EUI to v77.2.2 (#155208)
  [RAM][Maintenance Window][8.8]Fix window maintenance workflow (#156427)
  [DOCS] Case file attachments (#156459)
  [D4C] additional error handling for 'block' action added + policy editor UI fixes (#156629)
  [Enterprise Search] refactor(SearchApplications): rename telemetry ids (#156733)
  [Enterprise Search] Add telemetry to ELSER deployment buttons + error (#156545)
  [Security Solution] fixes Data Quality dashboard errors when a `basePath` is configured (#156233)
  [Logs onboarding] StepsFooter outside of main panel (#156686)
  [Security Solution] Add a migration to unmute custom Security Solution rules (#156593)
  [Enterprise Search][Behavioral Analytics] Update formulas (#156704)
  Add API Events to Endpoint Security Advanced Policy (#156718)
  ...
@lcawl lcawl mentioned this pull request May 8, 2023
Merged
kibanamachine added a commit that referenced this pull request May 8, 2023
@kibanamachine @guskovaue @lcawl
[8.8] [RAM] Docs for slack improvements (#153885) (#156794)
4a7d2b3 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[RAM] Docs for slack improvements
(#153885)](#153885)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2023-05-05T07:32:45Z","message":"[RAM]
Docs for slack improvements (#153885)\n\n## Summary\r\n\r\nDocs for new
Slack connector\r\n\r\n###
Preview\r\n\r\n\r\nhttps://kibana_153885.docs-preview.app.elstc.co/guide/en/kibana/master/slack-action-type.html\r\n\r\n---------\r\n\r\nCo-authored-by:
lcawl <lcawley@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4dd6d1a277953098b4f308253a889ab50f0c4ef5","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","docs","Feature:Actions/ConnectorTypes","ui-copy","backport:prev-minor","v8.8.0","v8.9.0"],"number":153885,"url":"https://github.com/elastic/kibana/pull/153885","mergeCommit":{"message":"[RAM]
Docs for slack improvements (#153885)\n\n## Summary\r\n\r\nDocs for new
Slack connector\r\n\r\n###
Preview\r\n\r\n\r\nhttps://kibana_153885.docs-preview.app.elstc.co/guide/en/kibana/master/slack-action-type.html\r\n\r\n---------\r\n\r\nCo-authored-by:
lcawl <lcawley@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4dd6d1a277953098b4f308253a889ab50f0c4ef5"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/153885","number":153885,"mergeCommit":{"message":"[RAM]
Docs for slack improvements (#153885)\n\n## Summary\r\n\r\nDocs for new
Slack connector\r\n\r\n###
Preview\r\n\r\n\r\nhttps://kibana_153885.docs-preview.app.elstc.co/guide/en/kibana/master/slack-action-type.html\r\n\r\n---------\r\n\r\nCo-authored-by:
lcawl <lcawley@elastic.co>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"4dd6d1a277953098b4f308253a889ab50f0c4ef5"}}]}]
BACKPORT-->

---------

Co-authored-by: Julia <iuliia.guskova@elastic.co>
Co-authored-by: Lisa Cawley <lcawley@elastic.co>
@lcawl lcawl mentioned this pull request Jun 27, 2023
Closed
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@lcawl lcawl lcawl approved these changes

Assignees

@guskovaue guskovaue

Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) docs Feature:Actions/ConnectorTypes Issues related to specific Connector Types on the Actions Framework release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) ui-copy Review of UI copy with docs team is recommended v8.8.0 v8.9.0
Projects
No open projects
AppEx: ResponseOps - Rules & Alerts Management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@guskovaue @kibana-ci @elasticmachine @kibanamachine @XavierM @lcawl