-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor KibanaMigrator, improve readability, maintainability and UT #155693
Merged
gsoldevila
merged 14 commits into
elastic:main
from
gsoldevila:dot-kibana-split-refactor-kibana-migrator
Jun 1, 2023
Merged
Changes from 6 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
7df3d80
Refactor KibanaMigrator, improve readability, maintainability and UT …
gsoldevila 04811ec
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila 765584b
Add missing params in calls to getKibanaMigratorTestKit(); misc code …
gsoldevila 9dc8e0c
Fix outdated fixtures
gsoldevila a3cd1c9
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila b215598
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila 6897e52
Undo incorrect imports' changes
gsoldevila 76e38b7
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila 1bb5e2b
Fix type errors
gsoldevila d7ecf67
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila cca0f9e
Fix type errors, attempt #2
gsoldevila 9d4d2af
One more
gsoldevila 9f07108
Fix more incorrect imports
gsoldevila 573ebbb
Merge branch 'main' into dot-kibana-split-refactor-kibana-migrator
gsoldevila File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
packages/core/saved-objects/core-saved-objects-base-server-internal/src/constants.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0 and the Server Side Public License, v 1; you may not use this file except | ||
* in compliance with, at your election, the Elastic License 2.0 or the Server | ||
* Side Public License, v 1. | ||
*/ | ||
|
||
import { IndexTypesMap } from './mappings'; | ||
|
||
/** | ||
* This map holds the default breakdown of SO types per index (pre 8.8.0) | ||
*/ | ||
export const DEFAULT_INDEX_TYPES_MAP: IndexTypesMap = { | ||
'.kibana_task_manager': ['task'], | ||
'.kibana': [ | ||
'action', | ||
'action_task_params', | ||
'alert', | ||
'api_key_pending_invalidation', | ||
'apm-indices', | ||
'apm-server-schema', | ||
'apm-service-group', | ||
'apm-telemetry', | ||
'app_search_telemetry', | ||
'application_usage_daily', | ||
'application_usage_totals', | ||
'book', | ||
'canvas-element', | ||
'canvas-workpad', | ||
'canvas-workpad-template', | ||
'cases', | ||
'cases-comments', | ||
'cases-configure', | ||
'cases-connector-mappings', | ||
'cases-telemetry', | ||
'cases-user-actions', | ||
'config', | ||
'config-global', | ||
'connector_token', | ||
'core-usage-stats', | ||
'csp-rule-template', | ||
'dashboard', | ||
'endpoint:user-artifact-manifest', | ||
'enterprise_search_telemetry', | ||
'epm-packages', | ||
'epm-packages-assets', | ||
'event_loop_delays_daily', | ||
'exception-list', | ||
'exception-list-agnostic', | ||
'file', | ||
'file-upload-usage-collection-telemetry', | ||
'fileShare', | ||
'fleet-fleet-server-host', | ||
'fleet-message-signing-keys', | ||
'fleet-preconfiguration-deletion-record', | ||
'fleet-proxy', | ||
'graph-workspace', | ||
'guided-onboarding-guide-state', | ||
'guided-onboarding-plugin-state', | ||
'index-pattern', | ||
'infrastructure-monitoring-log-view', | ||
'infrastructure-ui-source', | ||
'ingest-agent-policies', | ||
'ingest-download-sources', | ||
'ingest-outputs', | ||
'ingest-package-policies', | ||
'ingest_manager_settings', | ||
'inventory-view', | ||
'kql-telemetry', | ||
'legacy-url-alias', | ||
'lens', | ||
'lens-ui-telemetry', | ||
'map', | ||
'metrics-explorer-view', | ||
'ml-job', | ||
'ml-module', | ||
'ml-trained-model', | ||
'monitoring-telemetry', | ||
'osquery-manager-usage-metric', | ||
'osquery-pack', | ||
'osquery-pack-asset', | ||
'osquery-saved-query', | ||
'query', | ||
'rules-settings', | ||
'sample-data-telemetry', | ||
'search', | ||
'search-session', | ||
'search-telemetry', | ||
'searchableList', | ||
'security-rule', | ||
'security-solution-signals-migration', | ||
'siem-detection-engine-rule-actions', | ||
'siem-ui-timeline', | ||
'siem-ui-timeline-note', | ||
'siem-ui-timeline-pinned-event', | ||
'slo', | ||
'space', | ||
'spaces-usage-stats', | ||
'synthetics-monitor', | ||
'synthetics-param', | ||
'synthetics-privates-locations', | ||
'tag', | ||
'telemetry', | ||
'todo', | ||
'ui-metric', | ||
'upgrade-assistant-ml-upgrade-operation', | ||
'upgrade-assistant-reindex-operation', | ||
'uptime-dynamic-settings', | ||
'uptime-synthetics-api-key', | ||
'url', | ||
'usage-counters', | ||
'visualization', | ||
'workplace_search_telemetry', | ||
], | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're importing the client-side, deprecated versions by doing so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, will undo these changes!