Refactor KibanaMigrator, improve readability, maintainability and UT #155693
+988
−661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
TinaHeiligers
approved these changes
Apr 27, 2023
| // .kibana_task_manager migrator is NOT involved in relocation, must not sync | ||
| expect(logs).toMatch('[.kibana_task_manager] LEGACY_REINDEX_WAIT_FOR_TASK -> LEGACY_DELETE.'); | ||
| expect(logs).toMatch('[.kibana_task_manager] CREATE_REINDEX_TEMP'); | ||
| // .kibana_task_manager migrator is NOT involved in relocation, must not sync with others |
There was a problem hiding this comment.
Thanks for leaving that comment here!
pgayvallet
reviewed
May 5, 2023
| @@ -69,4 +69,4 @@ export type { | |||
| SavedObjectAttributes, | |||
| SavedObjectAttributeSingle, | |||
| SavedObjectReference, | |||
| } from '@kbn/core-saved-objects-common/src/server_types'; | |||
There was a problem hiding this comment.
You're importing the client-side, deprecated versions by doing so.
There was a problem hiding this comment.
Nice catch, will undo these changes!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
rudolf
added
the
Epic:ScaleMigrations
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
gsoldevila
added a commit
to gsoldevila/kibana
that referenced
this pull request
Jun 2, 2023
…lastic#155693) Addresses the following feedback: elastic#154151 (comment) Similar to what has been done for ZDT, the goal of this PR is to extract the logic of the `runV2Migration()` from the `KibanaMigrator` into a separate file. The PR also fixes some incomplete / incorrect UTs and adds a few missing ones. (cherry picked from commit 06c337f) # Conflicts: # packages/core/saved-objects/core-saved-objects-migration-server-internal/src/kibana_migrator.test.ts # packages/core/saved-objects/core-saved-objects-migration-server-internal/src/kibana_migrator.ts # packages/core/saved-objects/core-saved-objects-migration-server-internal/src/run_resilient_migrator.ts # src/core/server/integration_tests/saved_objects/migrations/kibana_migrator_test_kit.ts
gsoldevila
added a commit
that referenced
this pull request
Jun 3, 2023
…nd UT (#155693) (#158953) # Backport This will backport the following commits from `main` to `8.8`: - [Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)](#155693) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"gerard.soldevila@elastic.co"},"sourceCommit":{"committedDate":"2023-06-01T12:47:40Z","message":"Refactor KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com//pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","enhancement","technical debt","release_note:skip","backport:skip","Feature:Migrations","Epic:KBNA-7838","v8.9.0"],"number":155693,"url":"#155693 KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com//pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#155693 KibanaMigrator, improve readability, maintainability and UT (#155693)\n\nAddresses the following feedback:\r\nhttps://github.com//pull/154151#discussion_r1158470566\r\n\r\nSimilar to what has been done for ZDT, the goal of this PR is to extract\r\nthe logic of the `runV2Migration()` from the `KibanaMigrator` into a\r\nseparate file.\r\n\r\nThe PR also fixes some incomplete / incorrect UTs and adds a few missing\r\nones.","sha":"06c337f903a5b310f8a21a66065b186bbbc9642e"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
sloanelybutsurely
pushed a commit
to sloanelybutsurely/kibana
that referenced
this pull request
Jun 6, 2023
…lastic#155693) Addresses the following feedback: elastic#154151 (comment) Similar to what has been done for ZDT, the goal of this PR is to extract the logic of the `runV2Migration()` from the `KibanaMigrator` into a separate file. The PR also fixes some incomplete / incorrect UTs and adds a few missing ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following feedback:
#154151 (comment)
Similar to what has been done for ZDT, the goal of this PR is to extract the logic of the
runV2Migration()from theKibanaMigratorinto a separate file.The PR also fixes some incomplete / incorrect UTs and adds a few missing ones.