Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enterprise Search] Fix wording on content settings page #155383

Merged
merged 3 commits into from
Apr 24, 2023
Merged

[Enterprise Search] Fix wording on content settings page #155383

merged 3 commits into from
Apr 24, 2023

Conversation

sphilipse
Copy link
Member

Summary

This updates the content on the content settings page.

Screenshot 2023-04-20 at 14 02 02

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0 labels Apr 20, 2023
@sphilipse sphilipse requested review from a team April 20, 2023 12:03
@sphilipse sphilipse requested a review from a team as a code owner April 20, 2023 12:03
leemthompo
leemthompo approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doclink looks good to me.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #32 / cases security and spaces enabled: basic Common delete_comments alerts security_solution should remove only one case

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.3MB 2.3MB -38.0B
lists 156.8KB 156.9KB +52.0B
total +14.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 352.5KB 352.6KB +52.0B
enterpriseSearch 30.5KB 30.6KB +141.0B
total +193.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse enabled auto-merge (squash) April 21, 2023 11:56
gchaps
gchaps approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doclink LGTM

@sphilipse sphilipse merged commit 953437f into elastic:main Apr 24, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joemcelroy joemcelroy joemcelroy approved these changes

@sloanelybutsurely sloanelybutsurely sloanelybutsurely approved these changes

@leemthompo leemthompo leemthompo approved these changes

@gchaps gchaps gchaps approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sphilipse @kibana-ci @joemcelroy @sloanelybutsurely @leemthompo @gchaps @kibanamachine