Skip to content

Commit

Permalink
[Enterprise Search] Fix wording on content settings page (#155383)
Browse files Browse the repository at this point in the history
## Summary
This updates the content on the content settings page.

<img width="1024" alt="Screenshot 2023-04-20 at 14 02 02"
src="https://user-images.githubusercontent.com/94373878/233360104-c6c84b35-fc33-4a20-9be7-0c6d4d57841a.png">
  • Loading branch information
sphilipse authored Apr 24, 2023
1 parent d2c4c32 commit 953437f
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 25 deletions.
1 change: 1 addition & 0 deletions packages/kbn-doc-links/src/get_doc_links.ts
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ export const getDocLinks = ({ kibanaBranch }: GetDocLinkOptions): DocLinks => {
licenseManagement: `${ENTERPRISE_SEARCH_DOCS}license-management.html`,
machineLearningStart: `${ENTERPRISE_SEARCH_DOCS}machine-learning-start.html`,
mailService: `${ENTERPRISE_SEARCH_DOCS}mailer-configuration.html`,
mlDocumentEnrichment: `${ENTERPRISE_SEARCH_DOCS}document-enrichment.html`,
start: `${ENTERPRISE_SEARCH_DOCS}start.html`,
syncRules: `${ENTERPRISE_SEARCH_DOCS}sync-rules.html`,
troubleshootSetup: `${ENTERPRISE_SEARCH_DOCS}troubleshoot-setup.html`,
Expand Down
1 change: 1 addition & 0 deletions packages/kbn-doc-links/src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ export interface DocLinks {
readonly licenseManagement: string;
readonly machineLearningStart: string;
readonly mailService: string;
readonly mlDocumentEnrichment: string;
readonly start: string;
readonly syncRules: string;
readonly troubleshootSetup: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ import { useActions, useValues } from 'kea';
import { EuiButton, EuiLink, EuiSpacer } from '@elastic/eui';
import { i18n } from '@kbn/i18n';

import { FormattedMessage } from '@kbn/i18n-react';

import { docLinks } from '../../../shared/doc_links';
import { EnterpriseSearchContentPageTemplate } from '../layout/page_template';

Expand All @@ -36,6 +38,21 @@ export const Settings: React.FC = () => {
}),
]}
pageHeader={{
description: (
<FormattedMessage
id="xpack.enterpriseSearch.content.settings.description"
defaultMessage="These settings apply to all new Elasticsearch indices created by Enterprise Search ingestion mechanisms. For API ingest-based indices, remember to include the pipeline when you ingest documents. These features are powered by {link}."
values={{
link: (
<EuiLink href={docLinks.ingestPipelines} target="_blank">
{i18n.translate('xpack.enterpriseSearch.content.settings.ingestLink', {
defaultMessage: 'ingest pipelines',
})}
</EuiLink>
),
}}
/>
),
pageTitle: i18n.translate('xpack.enterpriseSearch.content.settings.headerTitle', {
defaultMessage: 'Content Settings',
}),
Expand Down Expand Up @@ -69,19 +86,12 @@ export const Settings: React.FC = () => {
'xpack.enterpriseSearch.content.settings.contentExtraction.description',
{
defaultMessage:
'Allow all ingestion mechanisms on your Enterprise Search deployment to extract searchable content from binary files, like PDFs and Word documents. This setting applies to all new Elasticsearch indices created by an Enterprise Search ingestion mechanism.',
'Extract searchable content from binary files, like PDFs and Word documents.',
}
)}
label={i18n.translate('xpack.enterpriseSearch.content.settings.contactExtraction.label', {
defaultMessage: 'Content extraction',
})}
link={
<EuiLink href={docLinks.ingestPipelines} target="_blank">
{i18n.translate('xpack.enterpriseSearch.content.settings.contactExtraction.link', {
defaultMessage: 'Learn more about content extraction',
})}
</EuiLink>
}
onChange={() =>
setPipeline({
...pipelineState,
Expand All @@ -105,13 +115,6 @@ export const Settings: React.FC = () => {
label={i18n.translate('xpack.enterpriseSearch.content.settings.whitespaceReduction.label', {
defaultMessage: 'Whitespace reduction',
})}
link={
<EuiLink href={docLinks.ingestPipelines} external>
{i18n.translate('xpack.enterpriseSearch.content.settings.whitespaceReduction.link', {
defaultMessage: 'Learn more about whitespace reduction',
})}
</EuiLink>
}
onChange={() =>
setPipeline({
...pipelineState,
Expand Down Expand Up @@ -139,9 +142,9 @@ export const Settings: React.FC = () => {
defaultMessage: 'ML Inference',
})}
link={
<EuiLink href={docLinks.ingestPipelines} target="_blank">
<EuiLink href={docLinks.mlDocumentEnrichment} target="_blank">
{i18n.translate('xpack.enterpriseSearch.content.settings.mlInference.link', {
defaultMessage: 'Learn more about content extraction',
defaultMessage: 'Learn more about document enrichment with ML',
})}
</EuiLink>
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { i18n } from '@kbn/i18n';
interface SettingsPanelProps {
description: string;
label: string;
link: React.ReactNode;
link?: React.ReactNode;
onChange: (event: EuiSwitchEvent) => void;
title: string;
value: boolean;
Expand Down Expand Up @@ -61,7 +61,7 @@ export const SettingsPanel: React.FC<SettingsPanelProps> = ({
<EuiFlexItem>
<EuiSwitch checked={value} label={label} onChange={onChange} />
</EuiFlexItem>
<EuiFlexItem grow={false}>{link}</EuiFlexItem>
{link && <EuiFlexItem grow={false}>{link}</EuiFlexItem>}
</EuiFlexGroup>
</EuiSplitPanel.Inner>
</EuiSplitPanel.Outer>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class DocLinks {
public languageClients: string;
public licenseManagement: string;
public machineLearningStart: string;
public mlDocumentEnrichment: string;
public pluginsIngestAttachment: string;
public queryDsl: string;
public searchUIAppSearch: string;
Expand Down Expand Up @@ -219,6 +220,7 @@ class DocLinks {
this.languageClients = '';
this.licenseManagement = '';
this.machineLearningStart = '';
this.mlDocumentEnrichment = '';
this.pluginsIngestAttachment = '';
this.queryDsl = '';
this.searchUIAppSearch = '';
Expand Down Expand Up @@ -340,6 +342,7 @@ class DocLinks {
this.languageClients = docLinks.links.enterpriseSearch.languageClients;
this.licenseManagement = docLinks.links.enterpriseSearch.licenseManagement;
this.machineLearningStart = docLinks.links.enterpriseSearch.machineLearningStart;
this.mlDocumentEnrichment = docLinks.links.enterpriseSearch.mlDocumentEnrichment;
this.pluginsIngestAttachment = docLinks.links.plugins.ingestAttachment;
this.queryDsl = docLinks.links.query.queryDsl;
this.searchUIAppSearch = docLinks.links.searchUI.appSearch;
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/fr-FR.json
Original file line number Diff line number Diff line change
Expand Up @@ -12711,7 +12711,6 @@
"xpack.enterpriseSearch.content.searchIndices.syncStatus.columnTitle": "Statut",
"xpack.enterpriseSearch.content.settings.breadcrumb": "Paramètres",
"xpack.enterpriseSearch.content.settings.contactExtraction.label": "Extraction du contenu",
"xpack.enterpriseSearch.content.settings.contactExtraction.link": "En savoir plus sur l'extraction de contenu",
"xpack.enterpriseSearch.content.settings.contentExtraction.description": "Autoriser tous les mécanismes d'ingestion de votre déploiement Enterprise Search à extraire le contenu interrogeable des fichiers binaires tels que les documents PDF et Word. Ce paramètre s'applique à tous les nouveaux index Elasticsearch créés par un mécanisme d'ingestion Enterprise Search.",
"xpack.enterpriseSearch.content.settings.contentExtraction.descriptionTwo": "Vous pouvez également activer ou désactiver cette fonctionnalité pour un index spécifique sur la page de configuration de l'index.",
"xpack.enterpriseSearch.content.settings.contentExtraction.title": "Extraction de contenu de l'ensemble du déploiement",
Expand All @@ -12725,7 +12724,6 @@
"xpack.enterpriseSearch.content.settings.whitespaceReduction.deploymentHeaderTitle": "Réduction d'espaces sur l'ensemble du déploiement",
"xpack.enterpriseSearch.content.settings.whiteSpaceReduction.description": "La réduction d'espaces supprimera le contenu de texte intégral des espaces par défaut.",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.label": "Réduction d'espaces",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.link": "En savoir plus sur la réduction d'espaces",
"xpack.enterpriseSearch.content.shared.result.header.metadata.deleteDocument": "Supprimer le document",
"xpack.enterpriseSearch.content.shared.result.header.metadata.title": "Métadonnées du document",
"xpack.enterpriseSearch.content.sources.basicRulesTable.includeEverythingMessage": "Inclure tout le reste à partir de cette source",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -12710,7 +12710,6 @@
"xpack.enterpriseSearch.content.searchIndices.syncStatus.columnTitle": "ステータス",
"xpack.enterpriseSearch.content.settings.breadcrumb": "設定",
"xpack.enterpriseSearch.content.settings.contactExtraction.label": "コンテンツ抽出",
"xpack.enterpriseSearch.content.settings.contactExtraction.link": "コンテンツ抽出の詳細",
"xpack.enterpriseSearch.content.settings.contentExtraction.description": "エンタープライズ サーチデプロイですべてのインジェストメソッドで、PDFやWordドキュメントなどのバイナリファイルから検索可能なコンテンツを抽出できます。この設定は、エンタープライズ サーチインジェストメカニズムで作成されたすべての新しいElasticsearchインデックスに適用されます。",
"xpack.enterpriseSearch.content.settings.contentExtraction.descriptionTwo": "インデックスの構成ページで、特定のインデックスに対して、この機能を有効化または無効化することもできます。",
"xpack.enterpriseSearch.content.settings.contentExtraction.title": "デプロイレベルのコンテンツ抽出",
Expand All @@ -12724,7 +12723,6 @@
"xpack.enterpriseSearch.content.settings.whitespaceReduction.deploymentHeaderTitle": "デプロイレベルの空白削除",
"xpack.enterpriseSearch.content.settings.whiteSpaceReduction.description": "空白削除では、デフォルトで全文コンテンツから空白を削除します。",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.label": "空白削除",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.link": "空白削除の詳細",
"xpack.enterpriseSearch.content.shared.result.header.metadata.deleteDocument": "ドキュメントを削除",
"xpack.enterpriseSearch.content.shared.result.header.metadata.title": "ドキュメントメタデータ",
"xpack.enterpriseSearch.content.sources.basicRulesTable.includeEverythingMessage": "このソースの他のすべての項目を含める",
Expand Down
2 changes: 0 additions & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -12711,7 +12711,6 @@
"xpack.enterpriseSearch.content.searchIndices.syncStatus.columnTitle": "状态",
"xpack.enterpriseSearch.content.settings.breadcrumb": "设置",
"xpack.enterpriseSearch.content.settings.contactExtraction.label": "内容提取",
"xpack.enterpriseSearch.content.settings.contactExtraction.link": "详细了解内容提取",
"xpack.enterpriseSearch.content.settings.contentExtraction.description": "允许您的 Enterprise Search 部署上的所有采集机制从 PDF 和 Word 文档等二进制文件中提取可搜索内容。此设置适用于由 Enterprise Search 采集机制创建的所有新 Elasticsearch 索引。",
"xpack.enterpriseSearch.content.settings.contentExtraction.descriptionTwo": "您还可以在索引的配置页面针对特定索引启用或禁用此功能。",
"xpack.enterpriseSearch.content.settings.contentExtraction.title": "部署广泛内容提取",
Expand All @@ -12725,7 +12724,6 @@
"xpack.enterpriseSearch.content.settings.whitespaceReduction.deploymentHeaderTitle": "部署广泛的空白缩减",
"xpack.enterpriseSearch.content.settings.whiteSpaceReduction.description": "默认情况下,空白缩减将清除空白的全文本内容。",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.label": "空白缩减",
"xpack.enterpriseSearch.content.settings.whitespaceReduction.link": "详细了解空白缩减",
"xpack.enterpriseSearch.content.shared.result.header.metadata.deleteDocument": "删除文档",
"xpack.enterpriseSearch.content.shared.result.header.metadata.title": "文档元数据",
"xpack.enterpriseSearch.content.sources.basicRulesTable.includeEverythingMessage": "包括来自此源的所有其他内容",
Expand Down

0 comments on commit 953437f

Please sign in to comment.