-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Onboard maps
to cross-type search
#155148
[CM] Onboard maps
to cross-type search
#155148
Conversation
…earch-4-maps-onboard
…nt/kibana into d/2023-04-13-msearch-4-maps-onboard
maps
to cross-type search
Pinging @elastic/appex-sharedux (Team:SharedUX) |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks great! I left a few comments around typings.
Would the examples work better together if they both work with the "todos" content type?
examples/content_management_examples/public/examples/msearch/msearch_app.tsx
Outdated
Show resolved
Hide resolved
examples/content_management_examples/public/examples/msearch/msearch_table.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kibana-gis changes LGTM
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Public APIs missing exports
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @Dosant |
Summary
Part of #152224
Follow up to #153256
This PR onboards maps CM integration into the multi-type search (
msearch
). It isn't actually used anywhere in the user-facing UI yet, as first other types need to be migrated to CM.This PR also adds an example app to test the
msearch
end-to-end.