Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Onboard maps to cross-type search #155148

Merged
merged 14 commits into from
Apr 21, 2023

Conversation

Dosant
Copy link
Contributor

@Dosant Dosant commented Apr 18, 2023

Summary

Part of #152224
Follow up to #153256

This PR onboards maps CM integration into the multi-type search (msearch). It isn't actually used anywhere in the user-facing UI yet, as first other types need to be migrated to CM.

This PR also adds an example app to test the msearch end-to-end.

@Dosant Dosant changed the title D/2023 04 13 msearch 4 maps onboard [CM] Onboard maps to cross-type search Apr 18, 2023
@Dosant Dosant added release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) Feature:Content Management User generated content (saved objects) management labels Apr 18, 2023
@Dosant Dosant self-assigned this Apr 18, 2023
@Dosant Dosant marked this pull request as ready for review April 18, 2023 15:58
@Dosant Dosant requested review from a team as code owners April 18, 2023 15:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/appex-sharedux (Team:SharedUX)

@Dosant Dosant requested a review from sebelga April 18, 2023 15:58
@Dosant
Copy link
Contributor Author

Dosant commented Apr 19, 2023

@elasticmachine merge upstream

Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great! I left a few comments around typings.

Would the examples work better together if they both work with the "todos" content type?

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kibana-gis changes LGTM

@Dosant
Copy link
Contributor Author

Dosant commented Apr 21, 2023

@elasticmachine merge upstream

@Dosant Dosant enabled auto-merge (squash) April 21, 2023 13:38
@Dosant Dosant merged commit 6aa1491 into elastic:main Apr 21, 2023
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/object-versioning 48 50 +2
contentManagement 124 126 +2
total +4

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
contentManagement 7 6 -1
Unknown metric groups

API count

id before after diff
@kbn/object-versioning 53 55 +2
contentManagement 143 149 +6
total +8

ESLint disabled line counts

id before after diff
securitySolution 394 397 +3

Total ESLint disabled count

id before after diff
securitySolution 474 477 +3

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Dosant

@kibanamachine kibanamachine added v8.8.0 backport:skip This commit does not require backporting labels Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Content Management User generated content (saved objects) management release_note:skip Skip the PR/issue when compiling release notes Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) v8.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants