review improvements

elastic · Apr 20, 2023 · 7fdc84d · 7fdc84d
1 parent 8224761
commit 7fdc84d
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 8 deletions.
diff --git a/examples/content_management_examples/public/examples/index.tsx b/examples/content_management_examples/public/examples/index.tsx
@@ -9,7 +9,7 @@
 import React from 'react';
 import ReactDOM from 'react-dom';
 // eslint-disable-next-line no-restricted-imports
-import { Router, Switch, Route } from 'react-router-dom';
+import { Router, Switch, Route, Redirect } from 'react-router-dom';
 import { RedirectAppLinks } from '@kbn/shared-ux-link-redirect-app';
 import { EuiPageTemplate, EuiSideNav } from '@elastic/eui';
 import { AppMountParameters, CoreStart } from '@kbn/core/public';
@@ -53,9 +53,7 @@ export const renderApp = (
 
           <EuiPageTemplate.Section>
             <Switch>
-              <Route path="/" exact={true}>
-                <TodoApp contentClient={contentManagement.client} />
-              </Route>
+              <Redirect from="/" to="/todos" exact />
               <Route path="/todos">
                 <TodoApp contentClient={contentManagement.client} />
               </Route>

diff --git a/examples/content_management_examples/public/examples/msearch/msearch_app.tsx b/examples/content_management_examples/public/examples/msearch/msearch_app.tsx
@@ -25,7 +25,7 @@ export const MSearchApp = (props: {
       <I18nProvider>
         <TableListViewKibanaProvider
           core={{
-            application: props.core.application as any, // TODO: fix it on the TableListView side
+            application: props.core.application,
             notifications: props.core.notifications,
             overlays: props.core.overlays,
             http: props.core.http,

diff --git a/examples/content_management_examples/public/examples/msearch/msearch_table.tsx b/examples/content_management_examples/public/examples/msearch/msearch_table.tsx
@@ -53,6 +53,7 @@ export const MSearchTable = () => {
       entityNamePlural={`ContentItems`}
       tableListTitle={`MSearch Demo`}
       urlStateEnabled={false}
+      emptyPrompt={<>No data found. Try to install some sample data first.</>}
       onClickTitle={(item) => {
         alert(`Clicked item ${item.attributes.title} (${item.id})`);
       }}

diff --git a/packages/content-management/table_list/src/services.tsx b/packages/content-management/table_list/src/services.tsx
@@ -80,9 +80,7 @@ export interface TableListViewKibanaDependencies {
   core: {
     application: {
       capabilities: {
-        advancedSettings?: {
-          save: boolean;
-        };
+        [key: string]: Readonly<Record<string, boolean | Record<string, boolean>>>;
       };
       getUrlForApp: (app: string, options: { path: string }) => string;
       currentAppId$: Observable<string | undefined>;