-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics/Anomaly Detection: Custom URLs - entity dropdown reflects Data View update #155096
[ML] Data Frame Analytics/Anomaly Detection: Custom URLs - entity dropdown reflects Data View update #155096
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a note on a potential simplification for the context mock.
@@ -9,13 +9,26 @@ | |||
import { shallow } from 'enzyme'; | |||
|
|||
jest.mock('../../../services/job_service', () => 'mlJobService'); | |||
jest.mock('../../../contexts/kibana', () => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a mock for this whole file in x-pack/plugins/ml/public/application/contexts/kibana/__mocks__/kibana_context.ts
so I wonder if just jest.mock('../../../contexts/kibana');
would work here?
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Summary
Related meta issue: #150375
This PR ensures that when data view is changed, the query entity dropdown values update to reflect the fields for the newly chosen data view. This makes it easier for example to build a link to Discover to view documents in a data view which contains useful contextual data, and has fields of the same name as those used in the job but which was not used to create the job e.g. data views which share a common
host.name
field.Checklist