Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add clearing rules table state functionality #150059

Merged
merged 16 commits into from
Feb 6, 2023
Merged

[Security Solution] Add clearing rules table state functionality #150059

merged 16 commits into from
Feb 6, 2023

Conversation

maximpn
Copy link
Contributor

@maximpn maximpn commented Feb 1, 2023 •
edited
Loading

Addresses: #145968

Summary

This PR adds functionality to clear persisted rules table state implemented in #140263.

Screen.Recording.2023-02-02.at.12.19.08.mov

Checklist

@maximpn maximpn added backport:skip This commit does not require backporting Feature:Detection Rules Security Solution rules and Detection Engine Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. release_note:feature Makes this part of the condensed release notes Team:Detection Rule Management Security Detection Rule Management Team labels Feb 1, 2023
@maximpn maximpn self-assigned this Feb 1, 2023
@maximpn maximpn added the v8.7.0 label Feb 1, 2023
@maximpn maximpn force-pushed the clear-rules-table-filters branch from b8f74d5 to c3fec08 Compare February 2, 2023 08:37
@maximpn maximpn marked this pull request as ready for review February 2, 2023 11:16
@maximpn maximpn requested a review from a team as a code owner February 2, 2023 11:16
@maximpn maximpn requested a review from banderror February 2, 2023 11:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@banderror banderror added release_note:enhancement Feature:Rule Management Security Solution Detection Rule Management area and removed release_note:feature Makes this part of the condensed release notes Feature:Detection Rules Security Solution rules and Detection Engine labels Feb 2, 2023
@banderror banderror linked an issue Feb 3, 2023 that may be closed by this pull request
[Security Solution] Add the ability to clear detection rules table filters #145968
Closed
@maximpn maximpn force-pushed the clear-rules-table-filters branch from c3fec08 to 7eb8448 Compare February 4, 2023 08:59
@maximpn maximpn force-pushed the clear-rules-table-filters branch from 7eb8448 to 4a68cb6 Compare February 6, 2023 09:42
banderror
banderror reviewed Feb 6, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR locally and reviewed the changes. Overall it looks very good to me but I have a few suggestions:

  • I'm missing e2e tests for this functionality and it would be great to add them in a follow-up PR + write a test plan. I think it should be a new test plan, separate from the one for the persistent rules table state.
  • I'm not sure I feel 100% ok about coupling this implementation with the persistent state (see my comment below). This is arguable, of course, so would be interested in hearing your opinion.

Let's sync on the comments and decide what can be addressed in this PR and what we could do after the FF.

banderror
banderror approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@banderror banderror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some cleanup needs to be done to make the CI happy, but other than that it looks great! Thank you for addressing my comments @maximpn. Let's 🚢 it!

...tection_engine/rule_management_ui/components/rules_table/rules_table/rules_table_context.tsx
isDefault: isDefaultState(filterOptions, sortingOptions, {
page,
perPage,
total: isInMemorySorting ? rules.length : total,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the in-memory mode has been deleted by @xcrzx in #149840

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 12.9MB 12.9MB +11.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @maximpn

@maximpn maximpn merged commit 62d5a2a into elastic:main Feb 6, 2023
@maximpn maximpn deleted the clear-rules-table-filters branch February 7, 2023 12:59
@joepeeples joepeeples mentioned this pull request Feb 14, 2023
Closed
@banderror banderror mentioned this pull request Feb 21, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banderror banderror banderror approved these changes

Assignees

@maximpn maximpn

Labels
backport:skip This commit does not require backporting Feature:Rule Management Security Solution Detection Rule Management area release_note:enhancement Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Security Solution] Add the ability to clear detection rules table filters
4 participants
@maximpn @elasticmachine @kibana-ci @banderror