-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain Log Rate Spikes: Fix loading state for grouping. #141770
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9c01868
Fix loading state for grouping.
walterra a38c41e
Merge branch 'main' into ml-aiops-fix-loading-bar
walterra 1db0605
Animated progress bar background.
walterra cd5d2f1
Migrate SCSS to emotion.
walterra 7fca8de
Tweak CSS.
walterra 69d235f
Remove obsolete comment.
walterra 614a839
Merge branch 'main' into ml-aiops-fix-loading-bar
walterra 77bca25
Cleanup css.
walterra 781620a
Merge branch 'ml-aiops-fix-loading-bar' of github.com:walterra/kibana…
walterra 7b32b6d
Merge branch 'main' into ml-aiops-fix-loading-bar
walterra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
...ackages/ml/aiops_components/src/progress_controls/use_animated_progress_bar_background.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,53 @@ | ||
/* | ||
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
* or more contributor license agreements. Licensed under the Elastic License | ||
* 2.0; you may not use this file except in compliance with the Elastic License | ||
* 2.0. | ||
*/ | ||
|
||
import { useMemo } from 'react'; | ||
|
||
import { css } from '@emotion/react'; | ||
|
||
export const useAnimatedProgressBarBackground = (color: string) => { | ||
return useMemo(() => { | ||
const progressBackground = { | ||
background: `repeating-linear-gradient( | ||
-45deg, | ||
transparent 0 6px, | ||
rgba(0, 0, 0, 0.1) 6px 12px | ||
), | ||
${color}`, | ||
// 0.707 = cos(45deg) | ||
backgroundSize: 'calc(12px / 0.707) 100%, 100% 800%', | ||
backgroundPosition: 'inherit', | ||
}; | ||
|
||
return css({ | ||
'progress[value]': { | ||
animation: 'aiopsAnimatedProgress 4s infinite linear', | ||
|
||
'::-webkit-progress-inner-element': { | ||
overflow: 'hidden', | ||
backgroundPosition: 'inherit', | ||
}, | ||
'::-webkit-progress-bar': { | ||
backgroundColor: 'transparent', | ||
backgroundPosition: 'inherit', | ||
}, | ||
|
||
'::-webkit-progress-value': progressBackground, | ||
'::-moz-progress-bar': progressBackground, | ||
|
||
'@keyframes aiopsAnimatedProgress': { | ||
'0%': { | ||
backgroundPosition: '0 0', | ||
}, | ||
'100%': { | ||
backgroundPosition: 'calc(10 * (12px / 0.707)) 100%', | ||
}, | ||
}, | ||
}, | ||
}); | ||
}, [color]); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if I get it right,
emotion
has an auto-prefixer emotion-js/emotion#1523.did you try it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The autocomplete/types for the available attributes still falls back to these webkit/moz based ones. It could be because of the differences in names to make this work. I was able to clean up a little bit the other styles though in 77bca25.